1130906 - [EME] Remove HTMLMediaElement.waitingFor

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

HTMLMediaElement.waitingFor has been removed from the EME draft spec. We should remove it from our implementation before shipping.

http://w3c.github.io/encrypted-media/#htmlmediaelement-extensions

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

JW: Would you be able to take this bug?

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

sure.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1130906_remove_waitFor-v1.patch

remove MediaWaitingFor from HTMLMediaElement.webidl.

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8561170 [details] [diff] [review]
1130906_remove_waitFor-v1.patch

Review of attachment 8561170 [details] [diff] [review]:
-----------------------------------------------------------------

Easy. You'll also need a DOM peer to r+ since you touched a WebIDL file.

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Hi bz,
Can you review the change in HTMLMediaElement.webidl which remove the MediaWaitingFor enum? Thanks.

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Try is green: https://tbpl.mozilla.org/?tree=Try&rev=8e962d3ef0d6

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8561170 [details] [diff] [review]
1130906_remove_waitFor-v1.patch

r=me

Comment 8

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Try is green: https://tbpl.mozilla.org/?tree=Try&rev=8e962d3ef0d6

inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/4298e517d29b

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4298e517d29b

Comment 10

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d72d2f792d90

Comment 11

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Beta patch

Patch for beta branch as part of EME platform uplift.

Comment 12

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8572357 [details] [diff] [review]
Beta patch

Requesting retroactive approval for Beta landing as part of EME platform uplift.

Comment 13

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8572357 [details] [diff] [review]
Beta patch

Approved for Beta as part of EME platform uplift.