Refactoring uitls.js, utils-node.js, utils-xpc.js

RESOLVED FIXED

Status

Firefox OS
Gaia::Build
P1
normal
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: rickychien, Assigned: rickychien)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Comment hidden (empty)
Created attachment 8561812 [details] [review]
[PullReq] RickyChien:bug-1130934 to mozilla-b2g:master
(Assignee)

Comment 2

3 years ago
Comment on attachment 8561812 [details] [review]
[PullReq] RickyChien:bug-1130934 to mozilla-b2g:master

Some of those useless APIs don't need to migrate to utils-node.js. I only test part of APIs in my WIP patch. We should verify and refine it in the following patches. Please check this patch kindly. Thanks!
Attachment #8561812 - Flags: review?(gduan)
Comment on attachment 8561812 [details] [review]
[PullReq] RickyChien:bug-1130934 to mozilla-b2g:master

Great job! just some nits un utils-node.js, r=gduan
Attachment #8561812 - Flags: review?(gduan) → review+
Created attachment 8564497 [details] [review]
[gaia-node-modules] RickyChien:bug-1130934 > mozilla-b2g:master
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Updated

3 years ago
Keywords: checkin-needed

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Updated

2 years ago
Priority: -- → P1
You need to log in before you can comment on or make changes to this bug.