1130948 - Failing mediasource-duration-boundaryconditions.html reftest

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P2)

Description

[Jean-Yves Avenard [:jya]]

This test sets the duration of the mediasource element to various insane values.

The test is marked as fail.

However, bug 1130839 has made it a problem, as it causes to attempt to seek to negative values.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Part1. Use mediasource duration to determine media element duration

Map mediasource duration to HTML Media Element's duration.

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: Part2. Ensure we don't overflow when setting duration

Make sure we don't overflow when calculating our duration in microseconds. Make it big instead.

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: Update web-ref results

We pass all those tests now.

Comment 4

[Jean-Yves Avenard [:jya]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/8df52c8e52e3
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/d4dc526e2abd
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/569cbe9c6036

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8df52c8e52e3
https://hg.mozilla.org/mozilla-central/rev/d4dc526e2abd
https://hg.mozilla.org/mozilla-central/rev/569cbe9c6036

Comment 6

[Ralph Giles (:rillian)]

Comment on attachment 8561290 [details] [diff] [review]
Part1. Use mediasource duration to determine media element duration

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Spec compliance. Less consistent testing. Harder to port later changes.
[Describe test coverage new/current, TreeHerder]: Landed on m-c. Web platform tests.
[Risks and why]: Changes are MSE-specific. Risk is low.
[String/UUID change made/needed]: None.

Comment 7

[Ralph Giles (:rillian)]

Oops. This does apply to 37.

Comment 8

[Ralph Giles (:rillian)]

Pushed first two parts to aurora with pre-approval from lmandel.

https://hg.mozilla.org/releases/mozilla-aurora/rev/1a200fe82ce5
https://hg.mozilla.org/releases/mozilla-aurora/rev/8be06da4f051

Comment 9

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8561290 [details] [diff] [review]
Part1. Use mediasource duration to determine media element duration

As stated, this bug was pre-approved to land with a set of changes for MSE. Marking the approval after the fact.