1130951 - (CopyPasteTest) Marionette test for selection carets' tilt function

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect)

Description

[Jeremy Chen ([e-mail])]

Marionette test for bug 1096169

Comment 1

[Jeremy Chen ([e-mail])]

Attachment: Part1: v1 A little refactoring for test_selectioncarets.py

Comment 2

[Jeremy Chen ([e-mail])]

Attachment: Part2: v1 Add test case for selection carets' tilt handling

Comment 3

[Jeremy Chen ([e-mail])]

Attachment: Part1: v2 A little refactoring for test_selectioncarets.py. r=automatedtester

Fix some typos.

Comment 4

[David Burns :automatedtester]

Comment on attachment 8561955 [details] [diff] [review]
Part2: v1 Add test case for selection carets' tilt handling

Review of attachment 8561955 [details] [diff] [review]:
-----------------------------------------------------------------

r+ only with the nit's fixed

::: layout/base/tests/marionette/test_selectioncarets.py
@@ +170,5 @@
> +        selection to be collapsed and the carets should be draggable.
> +        '''
> +
> +        sel = SelectionManager(el)
> +        print(sel.selected_content)

This looks like it was left for debugging, can you remove it please

@@ +189,5 @@
> +        # Caret width is 29px, so we make a series of hit tests for the two
> +        # tilted carets. If any of the hits is missed, selection would be
> +        # collapsed and both two carets should not be draggable.
> +        (caret3_x, caret3_y), (caret4_x, caret4_y) = sel.selection_carets_location()
> +        right_x = int(caret4_x+0.5)

please put spaces around the operator

@@ +190,5 @@
> +        # tilted carets. If any of the hits is missed, selection would be
> +        # collapsed and both two carets should not be draggable.
> +        (caret3_x, caret3_y), (caret4_x, caret4_y) = sel.selection_carets_location()
> +        right_x = int(caret4_x+0.5)
> +        for i in range (right_x, right_x+29, +1):

please put spaces around the operator

@@ +193,5 @@
> +        right_x = int(caret4_x+0.5)
> +        for i in range (right_x, right_x+29, +1):
> +            self.actions.press(el, i, caret4_y).release().perform()
> +
> +        left_x = int(caret3_x-0.5)

please put spaces around the operator

@@ +194,5 @@
> +        for i in range (right_x, right_x+29, +1):
> +            self.actions.press(el, i, caret4_y).release().perform()
> +
> +        left_x = int(caret3_x-0.5)
> +        for i in range (left_x, left_x-29, -1):

please put spaces around the operator

Comment 5

[Jeremy Chen ([e-mail])]

Attachment: Part2: v2 Add test case for selection carets' tilt handling. r=automatedtester (carry r+)

Remove debugging print, and put spaces around the operator.

Comment 6

[Jeremy Chen ([e-mail])]

try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=722725cc29c4

Comment 7

[Jeremy Chen ([e-mail])]

Attachment: Part2: v2 Add test case for selection carets' tilt handling. r=automatedtester (carry r+)

Change patch format from git to hg.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7c8d49762b13
https://hg.mozilla.org/integration/mozilla-inbound/rev/b3990dda83f8

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7c8d49762b13
https://hg.mozilla.org/mozilla-central/rev/b3990dda83f8