1131026 - nsITextInputProcessor.init(ForTests) should be renamed to nsITextInputProcessor.beginInputTransaction(ForInit)

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

I agree with your idea. The names are a little bit long, but it's not so problem.

Similarly, "notify-detached" should be renamed to "notify-end-input-transaction".

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8561377 [details] [diff] [review]
Patch

>+   * initForTest(), first.  See beginInputTransaction() for more detail of this.
s/initForTest/beginInputTransactionForTests/


So it is not clear to me whether we need this, if init() just worked as expected.
But either way.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Olli Pettay [:smaug] from comment #2)
> Comment on attachment 8561377 [details] [diff] [review]
> Patch
> 
> >+   * initForTest(), first.  See beginInputTransaction() for more detail of this.
> s/initForTest/beginInputTransactionForTests/

Oops, thanks! (I used replace of my editor but the comment misspelled...)

> So it is not clear to me whether we need this, if init() just worked as
> expected.
> But either way.

The method name, begin input transaction, sounds better to me because:

* the name is clearer what they do.
* the notification name is also clearer, especially the relation between the notification and these methods.
* it's better name to grep the method ;-) (init() is defined by a lot of classes!)

I'll land it, but if you have additional objections, I'll back it out.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/795e5c73a3a6

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/795e5c73a3a6

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsITextInputProcessor
https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsITextInputProcessorCallback