1131036 - API searches no longer working

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: API, defect)

Description

[Christian Holler (:decoder)]

This morning I noticed that searches in my bot that still uses BzAPI fail. I tried reproducing this in the browser and hit the problem pretty quickly:

https://api-dev.bugzilla.mozilla.org/latest/bug/?summary=Flash%20crash&summary_type=contains_all_words

Same for the other URL I found (the compat layer):

https://bugzilla.mozilla.org/bzapi/bug/?summary=Flash%20crash&summary_type=contains_all_words


That search isn't my actual search which is much more complex, but even this simple example from the documentation failed for me.

Comment 1

[:glob ✱]

fails on /rest/ searches too, with the same error:

https://bugzilla.mozilla.org/rest/bug/?summary=Flash%20crash&summary_type=contains_all_words
{
   "code" : 50,
   "documentation" : "https://wiki.mozilla.org/Bugzilla:BzAPI",
   "error" : true,
   "message" : "The function requires a ids argument, and that argument was not set."
}

investigating

Comment 2

[:glob ✱]

ah, this is because of the / after "bug".
decoder says this used to work until recently.

Comment 3

[:glob ✱]

dkl wants to look at this one.

Comment 4

[David Lawrence [:dkl]]

Attachment: 1131036_1.patch

Comment 5

[:glob ✱]

Comment on attachment 8561389 [details] [diff] [review]
1131036_1.patch

Review of attachment 8561389 [details] [diff] [review]:
-----------------------------------------------------------------

we should only be doing this for /bzapi/ requests, not all /rest/ requests.

Comment 6

[David Lawrence [:dkl]]

All working after patch:

http://localhost/bmo/bzapi/bug/?id=35
http://localhost/bmo/rest/bug/?id=35
http://localhost/bmo/bzapi/bug?id=35
http://localhost/bmo/bzapi/bug/35

dkl

Comment 7

[David Lawrence [:dkl]]

Attachment: 1131036_2.patch

Did not get to fix this the way I originally hoped so had to do the path fix much earlier in the request chain.

dkl

Comment 8

[Gervase Markham [:gerv]]

decoder: did you not see any of the messages about BzAPI going away imminently? Do you have a migration and testing plan in place?

Gerv

Comment 9

[Christian Holler (:decoder)]

I'm not using BzAPI directly, I'm using bztools which I think already switched to the compatibility layer. So this isn't only a problem with the old BzAPI interface. As far as I can tell, our bot works with the compatibility layer as well, but we haven't extensively tested it yet.

Comment 10

[:glob ✱]

Comment on attachment 8561400 [details] [diff] [review]
1131036_2.patch

Review of attachment 8561400 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob

Comment 11

[David Lawrence [:dkl]]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   7764fb5..5423c44  master -> master

Comment 12

[Gervase Markham [:gerv]]

(In reply to Christian Holler (:decoder) from comment #9)
> I'm not using BzAPI directly, I'm using bztools which I think already
> switched to the compatibility layer. 

Seemingly not, because you would have seen this problem already if that were so. The reason things broke is that we switched the BzAPI endpoint to use the compatibility layer directly. So that must have meant that before, you were not using the compatibility layer, because if you were, you'd have seen the problem weeks ago.

Gerv

Comment 13

[Christian Holler (:decoder)]

bztools has switched to the compatibility layer but we have not upgraded bztools yet, which is why we have not hit this problem so far.

Comment 14

[Gervase Markham [:gerv]]

(In reply to Christian Holler (:decoder) from comment #13)
> bztools has switched to the compatibility layer but we have not upgraded
> bztools yet

Which is precisely why I asked the question in comment 8 :-)

Gerv