Closed
Bug 1131069
Opened 10 years ago
Closed 10 years ago
Missing histograms in Nightly payloads
Categories
(Toolkit :: Telemetry, defect)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla38
Tracking | Status | |
---|---|---|
firefox38 | --- | fixed |
People
(Reporter: gfritzsche, Assigned: Dexter)
References
Details
Attachments
(2 files, 2 obsolete files)
2.38 KB,
patch
|
Details | Diff | Splinter Review | |
2.28 KB,
patch
|
Details | Diff | Splinter Review |
Per this graph we have a sharp drop in Nightly telemetry payload size:
http://ec2-50-112-66-71.us-west-2.compute.amazonaws.com:4352/#sandboxes/TelemetryChannelMetrics60DaysAggregator/outputs/TelemetryChannelMetrics60DaysAggregator.nightly.cbuf
Roberto found that we lost all histograms except TEST_RELEASE_OPTOUT and all keyed histograms except TELEMETRY_TEST_KEYED_RELEASE_OPTOUT.
Reporter | ||
Comment 1•10 years ago
|
||
From the above it looks like this is bug 1120369.
Apparently i didn't do the renaming of constants properly :(
DATASET_EXTENDED should now be DATASET_RELEASE_CHANNEL_OPTIN:
https://dxr.mozilla.org/mozilla-central/search?q=DATASET_EXTENDED&case=true
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry/nsITelemetry.idl#38
It looks like we just end up only sending the _OPTOUT histograms because DATASET_EXTENDED is |undefined| and hence |0|.
Reporter | ||
Comment 2•10 years ago
|
||
It looks like we have not noticed this in tests because bug 1129504 accidentally removed test coverage in the last days :(
Assignee | ||
Comment 3•10 years ago
|
||
Assignee: gfritzsche → alessio.placitelli
Status: NEW → ASSIGNED
Attachment #8561412 -
Flags: review?(gfritzsche)
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8561413 -
Flags: review?(gfritzsche)
Assignee | ||
Comment 5•10 years ago
|
||
Reporter | ||
Comment 6•10 years ago
|
||
Comment on attachment 8561412 [details] [diff] [review]
part 1 - Replaces the constants
Review of attachment 8561412 [details] [diff] [review]:
-----------------------------------------------------------------
r+ if this is green on try.
I think this could use a better commit message though - we could just read the diff to see what exactly was replaced.
Attachment #8561412 -
Flags: review?(gfritzsche) → review+
Reporter | ||
Comment 7•10 years ago
|
||
Comment on attachment 8561413 [details] [diff] [review]
part 2 - Fixes the test coverage.
Review of attachment 8561413 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good if this is green on try too.
Can we be a little more descriptive and mention the "missing telemetry payload test coverage" in the commit message instead of just naming the function?
Attachment #8561413 -
Flags: review?(gfritzsche) → review+
Assignee | ||
Comment 8•10 years ago
|
||
Fixed the commit message
Attachment #8561412 -
Attachment is obsolete: true
Assignee | ||
Comment 9•10 years ago
|
||
Fixed the commit message.
Attachment #8561413 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 10•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/5975847e7d0b
https://hg.mozilla.org/integration/fx-team/rev/c2fbc180eeb7
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 11•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5975847e7d0b
https://hg.mozilla.org/mozilla-central/rev/c2fbc180eeb7
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox38:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•