Inconsistency at tips in awesome screen

RESOLVED FIXED in Firefox 46

Status

()

Firefox for Android
Theme and Visual Design
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: Ioana Chiorean, Assigned: alex_johnson)

Tracking

(Blocks: 2 bugs)

Trunk
Firefox 46
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox46 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Reporter)

Description

3 years ago
Created attachment 8561460 [details]
Screenshot from 2015-02-09 17:07:49.png

Steps:
1. Go to Reading list panel
2. Go to History panel

Expected results:
- The tips given should have same type, color etc

Actual results:
- The one in history is in italic an orange under the main text, for the Reading List we have a section at the bottom of the page, grey only
Flags: needinfo?(alam)
Thanks for submitting this Ioana! We're looking to clean up the empty states of all our panels so they're more consistent. This is definitely one of the issues.
Blocks: 1091826
Flags: needinfo?(alam)
(Assignee)

Comment 2

3 years ago
Created attachment 8703293 [details]
MozReview Request: Bug 1131119 - Unified empty panel hints r+sebastian

Review commit: https://reviewboard.mozilla.org/r/29337/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29337/
Attachment #8703293 - Flags: review?(liuche)
(Assignee)

Updated

3 years ago
Assignee: nobody → me
Status: NEW → ASSIGNED
(Assignee)

Updated

3 years ago
Depends on: 1205236
(Assignee)

Comment 3

3 years ago
Comment on attachment 8703293 [details]
MozReview Request: Bug 1131119 - Unified empty panel hints r+sebastian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29337/diff/1-2/
(Assignee)

Comment 4

3 years ago
Created attachment 8703302 [details]
Screenshots

Comment 5

3 years ago
Comment on attachment 8703293 [details]
MozReview Request: Bug 1131119 - Unified empty panel hints r+sebastian

Chenxia is on vacation until next week. Maybe Sebastian can help do this review in the meantime.
Attachment #8703293 - Flags: review?(s.kaspari)
Comment on attachment 8703302 [details]
Screenshots

Antlam: Are you happy with the result? :)

Alex: Sorry for the delay. I'm now going to review the code!
Attachment #8703302 - Flags: feedback?(alam)
Attachment #8703293 - Flags: review?(s.kaspari) → review+
Comment on attachment 8703293 [details]
MozReview Request: Bug 1131119 - Unified empty panel hints r+sebastian

https://reviewboard.mozilla.org/r/29337/#review27031

LGTM.
Comment on attachment 8703302 [details]
Screenshots

Nice! Can we use "Tip:" rather than "TIP:" ?

Alex, are we going to clean up the rest of the alignment and padding stuff in bug 1091826 ?

Thanks again!
Flags: needinfo?(me)
Attachment #8703302 - Flags: feedback?(alam) → feedback+

Updated

3 years ago
Blocks: 1157964
(Assignee)

Comment 9

3 years ago
(In reply to Anthony Lam (:antlam) from comment #8)
> Comment on attachment 8703302 [details]
> Screenshots
> 
> Nice! Can we use "Tip:" rather than "TIP:" ?
> 
> Alex, are we going to clean up the rest of the alignment and padding stuff
> in bug 1091826 ?

Yeah, that's the plan!  :)
> 
> Thanks again!
Flags: needinfo?(me)
(Assignee)

Comment 10

3 years ago
Comment on attachment 8703293 [details]
MozReview Request: Bug 1131119 - Unified empty panel hints r+sebastian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29337/diff/2-3/
Attachment #8703293 - Attachment description: MozReview Request: Bug 1131119 - Unified empty panel hints r?liuche → MozReview Request: Bug 1131119 - Unified empty panel hints r+sebastian
(Assignee)

Updated

3 years ago
Attachment #8703293 - Flags: review?(liuche)
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Comment 13

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1377d52239c2
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
You need to log in before you can comment on or make changes to this bug.