1131119 - Inconsistency at tips in awesome screen

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Ioana Chiorean]

Attachment: Screenshot from 2015-02-09 17:07:49.png

Steps:
1. Go to Reading list panel
2. Go to History panel

Expected results:
- The tips given should have same type, color etc

Actual results:
- The one in history is in italic an orange under the main text, for the Reading List we have a section at the bottom of the page, grey only

Comment 1

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Thanks for submitting this Ioana! We're looking to clean up the empty states of all our panels so they're more consistent. This is definitely one of the issues.

Comment 2

[Alex Johnson (:alex_johnson)]

Attachment: MozReview Request: Bug 1131119 - Unified empty panel hints r+sebastian

Review commit: https://reviewboard.mozilla.org/r/29337/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29337/

Comment 3

[Alex Johnson (:alex_johnson)]

Comment on attachment 8703293 [details]
MozReview Request: Bug 1131119 - Unified empty panel hints r+sebastian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29337/diff/1-2/

Comment 4

[Alex Johnson (:alex_johnson)]

Attachment: Screenshots

Comment 5

[:Margaret Leibovic]

Comment on attachment 8703293 [details]
MozReview Request: Bug 1131119 - Unified empty panel hints r+sebastian

Chenxia is on vacation until next week. Maybe Sebastian can help do this review in the meantime.

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8703302 [details]
Screenshots

Antlam: Are you happy with the result? :)

Alex: Sorry for the delay. I'm now going to review the code!

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8703293 [details]
MozReview Request: Bug 1131119 - Unified empty panel hints r+sebastian

https://reviewboard.mozilla.org/r/29337/#review27031

LGTM.

Comment 8

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Comment on attachment 8703302 [details]
Screenshots

Nice! Can we use "Tip:" rather than "TIP:" ?

Alex, are we going to clean up the rest of the alignment and padding stuff in bug 1091826 ?

Thanks again!

Comment 9

[Alex Johnson (:alex_johnson)]

(In reply to Anthony Lam (:antlam) from comment #8)
> Comment on attachment 8703302 [details]
> Screenshots
> 
> Nice! Can we use "Tip:" rather than "TIP:" ?
> 
> Alex, are we going to clean up the rest of the alignment and padding stuff
> in bug 1091826 ?

Yeah, that's the plan!  :)
> 
> Thanks again!

Comment 10

[Alex Johnson (:alex_johnson)]

Comment on attachment 8703293 [details]
MozReview Request: Bug 1131119 - Unified empty panel hints r+sebastian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29337/diff/2-3/

Comment 11

[Alex Johnson (:alex_johnson)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b907524adfb6

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/1377d52239c2

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1377d52239c2