Closed
Bug 1131119
Opened 9 years ago
Closed 8 years ago
Inconsistency at tips in awesome screen
Categories
(Firefox for Android Graveyard :: Theme and Visual Design, defect)
Tracking
(firefox46 fixed)
RESOLVED
FIXED
Firefox 46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: ioana.chiorean, Assigned: alex_johnson)
References
Details
Attachments
(3 files)
Steps: 1. Go to Reading list panel 2. Go to History panel Expected results: - The tips given should have same type, color etc Actual results: - The one in history is in italic an orange under the main text, for the Reading List we have a section at the bottom of the page, grey only
Updated•9 years ago
|
Flags: needinfo?(alam)
Comment 1•9 years ago
|
||
Thanks for submitting this Ioana! We're looking to clean up the empty states of all our panels so they're more consistent. This is definitely one of the issues.
Blocks: 1091826
Flags: needinfo?(alam)
Updated•9 years ago
|
Depends on: onboarding-defaults
Updated•9 years ago
|
Blocks: onboarding-defaults
No longer depends on: onboarding-defaults
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/29337/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/29337/
Attachment #8703293 -
Flags: review?(liuche)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → me
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•8 years ago
|
||
Comment on attachment 8703293 [details] MozReview Request: Bug 1131119 - Unified empty panel hints r+sebastian Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29337/diff/1-2/
Assignee | ||
Comment 4•8 years ago
|
||
Comment 5•8 years ago
|
||
Comment on attachment 8703293 [details] MozReview Request: Bug 1131119 - Unified empty panel hints r+sebastian Chenxia is on vacation until next week. Maybe Sebastian can help do this review in the meantime.
Attachment #8703293 -
Flags: review?(s.kaspari)
Comment 6•8 years ago
|
||
Comment on attachment 8703302 [details]
Screenshots
Antlam: Are you happy with the result? :)
Alex: Sorry for the delay. I'm now going to review the code!
Attachment #8703302 -
Flags: feedback?(alam)
Updated•8 years ago
|
Attachment #8703293 -
Flags: review?(s.kaspari) → review+
Comment 7•8 years ago
|
||
Comment on attachment 8703293 [details] MozReview Request: Bug 1131119 - Unified empty panel hints r+sebastian https://reviewboard.mozilla.org/r/29337/#review27031 LGTM.
Comment 8•8 years ago
|
||
Comment on attachment 8703302 [details] Screenshots Nice! Can we use "Tip:" rather than "TIP:" ? Alex, are we going to clean up the rest of the alignment and padding stuff in bug 1091826 ? Thanks again!
Flags: needinfo?(me)
Attachment #8703302 -
Flags: feedback?(alam) → feedback+
Updated•8 years ago
|
Blocks: fennec-polish
Assignee | ||
Comment 9•8 years ago
|
||
(In reply to Anthony Lam (:antlam) from comment #8) > Comment on attachment 8703302 [details] > Screenshots > > Nice! Can we use "Tip:" rather than "TIP:" ? > > Alex, are we going to clean up the rest of the alignment and padding stuff > in bug 1091826 ? Yeah, that's the plan! :) > > Thanks again!
Flags: needinfo?(me)
Assignee | ||
Comment 10•8 years ago
|
||
Comment on attachment 8703293 [details] MozReview Request: Bug 1131119 - Unified empty panel hints r+sebastian Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29337/diff/2-3/
Attachment #8703293 -
Attachment description: MozReview Request: Bug 1131119 - Unified empty panel hints r?liuche → MozReview Request: Bug 1131119 - Unified empty panel hints r+sebastian
Assignee | ||
Updated•8 years ago
|
Attachment #8703293 -
Flags: review?(liuche)
Assignee | ||
Comment 11•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b907524adfb6
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 12•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/1377d52239c2
Keywords: checkin-needed
Comment 13•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1377d52239c2
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•