1131181 - Add focusmanager.testmode: true to default prefs for firefox-ui-tests

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, defect)

Description

[Barbara Miller (:galgeek)]

firefox-ui-tests require preference focusmanager.testmode set to true.

Comment 1

[Barbara Miller (:galgeek)]

Attachment: github_pull_request.txt

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Per bug 618470 there's a problem in our method for returning the focused chrome window here [1]. According to bug 618470: "getMostRecentWindow isn't supposed to do this. The focused window can be retrieved with nsIFocusManager::GetActiveWindow." This needs to be fixed before we can turn on the pref. Because it was turned on in marionette we need a hotfix today to get tests passing again. Henrik can you look into fixing this method?

[1] https://github.com/mozilla/firefox-ui-tests/blob/master/firefox_puppeteer/ui/windows.py#L39

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I wont have time today. Maybe Barbara can have a look at it? If it's not possible for her, I will check on Monday.

Comment 4

[Barbara Miller (:galgeek)]

Maybe this is helpful, an isFocused property referencing nsiFocusManager in js?

https://dxr.mozilla.org/mozilla-central/source/addon-sdk/source/lib/sdk/window/utils.js#224

I'll see if I can do something with this in a little bit.

Comment 5

[Chris Manchester (limited bugmail, email directly)]

Services.focus is a shorthand to get to nsIFocusManager. According to mdn [1] there's a "focusedWindow" property that could be what we want.

Comment 6

[Barbara Miller (:galgeek)]

In this context, it looks like we need the activeWindow property.

At least, that's working nicely with the test that's been failing with focusmanger.testmode: True.

I'll update the PR in a little bit.

Comment 7

[Barbara Miller (:galgeek)]

Comment on attachment 8561524 [details] [review]
github_pull_request.txt

I've updated the PR, and it's passed Travis.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8561524 [details] [review]
github_pull_request.txt

Great investigation! Thanks Barbara. I will get it landed in a bit.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

PR has been merged as https://github.com/mozilla/firefox-ui-tests/commit/b671f9b253b930005ac6c533fe627b4aa9f6ec75