1131214 - [RTL][Gallery] Screenshot information in Gallery shows filename mirrored

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect, P2)

Description

[Brogan Zumwalt [Inactive]]

Attachment: screenshot.png

Description:
With language set to Arabic, when user takes screenshot with device, then views screenshot information in Gallery the filename shows as  mirrored (e.g. "png.2015-02-09-14-27-49")

This is incorrect as filename is made up of numbers and LTR characters which should not be mirrored according to spec.

Images from other sources such as images taken with camera or imported into phone show as expected (e.g. "IMG_0001.jpg")


Repro Steps:
1) Update a Flame to 20150209010211
2) Set language to Arabic
3) Take screenshot
4) Launch Gallery and select screeshot
5) Tap detailed information icon

Actual:
Screenshot filename is mirrored.

Expected:
Strings made up of LTR characters/words and numeric characters should not be mirrored.

Environmental Variables:
Device: Flame 3.0 Master
Build ID: 20150209010211
Gaia: 0d7b35f23402c4cb29bca6b98280fec48a196dec
Gecko: 3436787a82d0
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Repro frequency: 3/3, 100%
See attached: screenshot, & logcat

Comment 1

[Brogan Zumwalt [Inactive]]

Attachment: Logcat

Comment 2

[Brogan Zumwalt [Inactive]]

Issue DOES occur in Flame 2.2

Screenshot filename is mirrored.

Device: Flame 2.2
Build ID: 20150209002504
Gaia: e827781324cbde91d2434b388f5dead3303a85ee
Gecko: 0552759956d3
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 3

[KTucker [:KTucker][Inactive 3/4/2016]]

Delphine, could you weigh in on the severity of this issue please?

Comment 4

[Delphine Lebédel [:delphine - OOO]]

I think this bug is valid. CCing Ahmed and Lizie just in case, so they can give their input if ever need be.
I wouldn't consider this issue a P1 though, but definitely good to have. Triaging as P2

Comment 5

[Hema Koka [:hema]]

Punam, could you investigate this bug?

Thanks
Hema

Comment 6

[Punam Dahiya [:pdahiya]]

Issue reported can be replicated for all files in gallery app with file name having number and special character (e.g. 2015_02_11.jpg). 

Taking bug to fix by explicitly specifying file name on info dialog to have direction ltr.

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] punamdahiya:Bug1131214 > mozilla-b2g:master

Comment 8

[Punam Dahiya [:pdahiya]]

Comment on attachment 8563499 [details] [review]
[gaia] punamdahiya:Bug1131214 > mozilla-b2g:master

Hi Wilson
Please review attached CSS patch that ensures file name in info view is not directional. Thanks!

Comment 9

[Punam Dahiya [:pdahiya]]

I have noticed similar issue in Video app. Video app displays video name in video list, fullscreen view and info view. Created bug 1132545 to triage and fix the bug for video app.

Comment 10

[Dylan Oliver [:doliver]]

triage: Please request approval for 2.2 if this fix is landed before the 2/23 FL date.

Comment 11

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/d6a13f8ddb8949e263d6a103897d5975c2035e18

Comment 12

[Punam Dahiya [:pdahiya]]

Comment on attachment 8563499 [details] [review]
[gaia] punamdahiya:Bug1131214 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Not a regression
[User impact] if declined: In RTL mode, gallery app while displaying info, file name starting with number and special characters will be mirrored.
[Testing completed]: On master
[Risk to taking this patch] (and alternatives if risky): Very low
[String changes made]:None

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/d439c087e52bd5f781f8bf861a0b351472da0291

Comment 14

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed on the latest Nightly  Flame KK 3.0 and 2.2 builds.

Actual Results: The file names are shown correctly.

Environmental Variables:
Device: Flame 3.0 KK (Full Flash) (319 MB)
BuildID: 20150223010224
Gaia: a6881205deae450757a8d1e1ed65e5e5be0ec633
Gecko: 86d2bb8bb1c9
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Environmental Variables:
Device: Flame 2.2 KK (Full Flash) (319 MB)
BuildID: 20150223002503
Gaia: 389542b71c89253c0d176d3b0bfb54e275c19bf1
Gecko: 9fd3441c8983
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 15

[Lancy(Leave from Mozilla)]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15190/