Closed
Bug 1131223
Opened 10 years ago
Closed 10 years ago
Add teardown to Firefox Puppeteer's test_windows to prevent cascade of errors/failures
Categories
(Testing :: Firefox UI Tests, defect)
Testing
Firefox UI Tests
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla38
People
(Reporter: galgeek, Assigned: galgeek, Mentored)
Details
Attachments
(1 file)
Tests in test_windows.py should use a teardown to close all windows at test end.
Tests occasionally fail because currently they do not.
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → galgeek
|
||
Comment 1•10 years ago
|
||
If this is a problem intermittently our tests are subtly broken and need to be fixed. If this is desirable for cases a test fails so that errors don't cascade to further tests, we should automatically fail the test if windows were leaked in addition to performing the cleanup so this doesn't end up papering over problematic tests.
|
|
Assignee | |
Updated•10 years ago
|
Summary: Add teardown to Firefox Puppeteer's test_windows.py including self.windows.close_all() → Add teardown to Firefox Puppeteer's test_windows to prevent cascade of errors/failures
|
|
Assignee | |
Comment 2•10 years ago
|
||
I wonder if it would be better for the close_all function itself to take care of preserving the browser window that must remain open for tests to continue.
Attachment #8561792 -
Flags: review?(hskupin)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8561792 [details] [review]
github_pull_request.txt
It's close, but needs some more tweaks.
Attachment #8561792 -
Flags: review?(hskupin) → review-
|
|
Assignee | |
Comment 4•10 years ago
|
||
Comment on attachment 8561792 [details] [review]
github_pull_request.txt
Thanks for your feedback!
I've updated the github PR.
Attachment #8561792 -
Flags: review?(hskupin)
|
|
||
Updated•10 years ago
|
Attachment #8561792 -
Flags: review?(hskupin) → review+
|
|
||
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
|
||
Updated•9 years ago
|
Product: Mozilla QA → Testing
You need to log in
before you can comment on or make changes to this bug.
Description
•