Status

()

Firefox for iOS
Data Storage
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: wesj, Assigned: wesj)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

47 bytes, text/x-github-pull-request
rnewman
: review+
nalexander
: feedback+
Details | Review | Splinter Review
(Assignee)

Description

3 years ago
We've got some bookmarks code already in place on iOS, but we should have a locally stored database using sqlite as well. This is for that.
(Assignee)

Updated

3 years ago
Blocks: 1127040
(Assignee)

Comment 1

3 years ago
Created attachment 8561667 [details] [review]
Pull request

This implements a sqlite datastore for bookmarks. I tried to keep from changing the existing code as much as I could. I don't love the existing code, but it was just to easy for this code to boil the ocean. I did change its ID field to a guid one, since most of our other data sources look that way.

I then deleted all the old unused code.
Attachment #8561667 - Flags: review?(rnewman)
Assignee: nobody → wjohnston
Status: NEW → ASSIGNED
OS: Mac OS X → iOS 8
Hardware: x86 → All
Attachment #8561667 - Flags: review?(rnewman)
Attachment #8561667 - Flags: review+
Attachment #8561667 - Flags: feedback?(nalexander)
Comment on attachment 8561667 [details] [review]
Pull request

I have some questions and concerns but nothing major, and no need to block on me getting my work reviewed.  Thanks, y'all!
Attachment #8561667 - Flags: feedback?(nalexander) → feedback+
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.