1131340 - Remove some C++11-isms that are not yet supported in the Gecko codebase (due to gcc 4.6)

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Matthew Gregan [:kinetik]]

Two of my recent changes, bug 1121258 and bug 1124021 introduced some C++11-isms that are green on all current T1 platforms, but fail with gcc 4.6.  Since we still support gcc 4.6 (for some reason), these changes need to be reverted.

Comment 1

[Matthew Gregan [:kinetik]]

Attachment: Avoid delegating constructors since GCC 4.6 lacks support.

Comment 2

[Matthew Gregan [:kinetik]]

Attachment: Avoid template aliasing since GCC 4.6 lacks support.

Comment 3

[Matthew Gregan [:kinetik]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ce6ddc1a1f7f

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8561734 [details] [diff] [review]
Avoid template aliasing since GCC 4.6 lacks support.

Review of attachment 8561734 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/gmp/GMPUtils.h
@@ +26,1 @@
>  

GMPUnique<GMPVideoEncodedFrame>::Ptr seems like a type name crying out to be typedef'd.

Comment 5

[Matthew Gregan [:kinetik]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9d40ef2ea8b8
https://hg.mozilla.org/integration/mozilla-inbound/rev/9a9b1ee1a69e

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9d40ef2ea8b8
https://hg.mozilla.org/mozilla-central/rev/9a9b1ee1a69e

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d102a4ff97be
https://hg.mozilla.org/releases/mozilla-beta/rev/e6af00cdcfe7

Comment 8

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch 2 - Beta patch

Patch for beta branch as part of EME platform uplift.

Comment 9

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch 1 - Beta patch

Patch for beta branch as part of EME platform uplift.

Comment 10

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8572356 [details] [diff] [review]
Patch 1 - Beta patch

Requesting retroactive approval for Beta landing as part of EME platform uplift.

Comment 11

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8572355 [details] [diff] [review]
Patch 2 - Beta patch

Requesting retroactive approval for Beta landing as part of EME platform uplift.

Comment 12

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8572356 [details] [diff] [review]
Patch 1 - Beta patch

Approved for Beta as part of EME platform uplift.