1131366 - [Homescreen][Edit] Moving the last app icon out of the first (top) app group will cause the group to delete (collapse) before the icon is dropped in another group

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Martin Shuman [:Marty]]

Attachment: logcat-homescreen-app-group.txt

Description:
The top-most app-group will delete when the last icon is moved out of it, but before it is dropped into another app-group.  This is inconsistent with moving the last icon out of other app-groups, and violates UX.


Repro Steps:
1) Update a Flame to 20150209010211
2) On the Homescreen, long tap any icon to enter Edit mode.
3) Drag an app up above the topmost app-group to create a new app group above it.
4) Drag that same app back down out of the topmost app group to another app-group below, but do not drop the app icon


Actual:
The topmost app group will collapse and delete before the app is dropped.


Expected:
The topmmost app group will not collapse or delete until after the app is dropped.

Environmental Variables:
Device: Flame 3.0
Build ID: 20150209010211
Gaia: 0d7b35f23402c4cb29bca6b98280fec48a196dec
Gecko: 3436787a82d0
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Repro frequency: 5/5
See attached: video clip (URL), logcat

--------------------------------------------------

This issue DOES occur on Flame 2.2
The topmost app group will collapse and delete before the app is dropped.

Environmental Variables:
Device: Flame 2.2
Build ID: 20150209002504
Gaia: e827781324cbde91d2434b388f5dead3303a85ee
Gecko: 0552759956d3
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

--------------------------------------------------

This issue does NOT occur on Flame 2.1 due to having a different design

Comment 1

[Chris Lord [:cwiiis]]

Taking to verify, and fix if necessary.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] Cwiiis:bug1131366-top-empty-group-disappears-during-drag > mozilla-b2g:master

Comment 3

[Chris Lord [:cwiiis]]

Comment on attachment 8562751 [details] [review]
[gaia] Cwiiis:bug1131366-top-empty-group-disappears-during-drag > mozilla-b2g:master

Fixes the issue. Writing a marionette test for this would be beyond painful (I'm not sure it'd be possible with the scrolling issues), so this gets a unit test instead.

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8562751 [details] [review]
[gaia] Cwiiis:bug1131366-top-empty-group-disappears-during-drag > mozilla-b2g:master

Looks good to me, I would recommend squashing into one commit as it's pretty simple and will help uplift. Thanks for the patch.

Comment 5

[Chris Lord [:cwiiis]]

Squashed and merged: https://github.com/mozilla-b2g/gaia/commit/428e1971257b209c0383d25314da7d763fe2fbde

Comment 6

[Chris Lord [:cwiiis]]

Comment on attachment 8562751 [details] [review]
[gaia] Cwiiis:bug1131366-top-empty-group-disappears-during-drag > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Can be confusing when dragging the last icon out of a group at the top of the screen
[Testing completed]: Manually and unit tested
[Risk to taking this patch] (and alternatives if risky): Low risk, very small change.
[String changes made]: None

Comment 7

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/5aab76ed57b908fc1f1d542b4d992da56c6b5e18

Comment 8

[SandKing]

Attachment: verified video: verify_1131366 .mp4

This issue has been verified successfully on latest Flame3.0
STR:
1. Move all of the apps from top-most app-group.
2. Wait to the last icon is moved out of it, but before it is dropped into another app-group.
**You can see the top-most app-group was not deleted
Occur Rate: 0/5
Verify video:"verify_1131366 .mp4".

Flame 3.0 build:
Gaia-Rev        d5a71cedb37dd45f439f672489db3994b349ac43
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/3094601af679
Build-ID        20150212010213
Version         38.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150212.042740
FW-Date         Thu Feb 12 04:27:51 EST 2015
Bootloader      L1TC000118D0

Comment 9

[SandKing]

This issue has been verified successfully on latest Flame2.2
STR:
1. Move all of the apps from top-most app-group.
2. Wait to the last icon is moved out of it, but before it is dropped into another app-group.
**You can see the top-most app-group was not deleted
Occur Rate: 0/5

Flame 2.2 build:
Build ID               20150214002504
Gaia Revision          ea64caf6d4ab03fc4472eca9f41f20d651d55fa9
Gaia Date              2015-02-13 05:27:43
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/6de30e6bbc84
Gecko Version          37.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150214.044811
Firmware Date          Sat Feb 14 04:48:22 EST 2015
Bootloader             L1TC000118D0