Closed
Bug 1131408
Opened 8 years ago
Closed 8 years ago
[Search] Clearing search term in Rocketbar leaves History and Default Search headers on screen
Categories
(Firefox OS Graveyard :: Gaia::Search, defect)
Tracking
(blocking-b2g:2.2+, b2g-v2.2 verified, b2g-master verified)
People
(Reporter: bzumwalt, Assigned: apastor)
References
Details
(Whiteboard: [systemsfe])
Attachments
(2 files)
16.27 KB,
image/png
|
Details | |
46 bytes,
text/x-github-pull-request
|
kgrandon
:
review+
bajaj
:
approval-gaia-v2.2+
|
Details | Review |
Description: When user searches for a term in Rocketbar then clears search term by pressing "X" button, the Default search header (e.g. "Google Search", "Yahoo Search", etc.) remains although no search results appear. If the search term brought up browsing history results, the "History" header will remain as well. Furthermore, if there were any Marketplace results, any remaining headers will be vertically offset by the amount of space that was previously taken up by the Marketplace results. Repro Steps: 1) Update a Flame to 20150209010211 2) Tap Rocketbar and enter a search term 3) Tap "X" button on Rocketbar to clear search term Actual: Default search and History headers remain visible in search results area. Expected: Search result area is blank in an empty state. Environmental Variables: Device: Flame 3.0 Master Build ID: 20150209010211 Gaia: 0d7b35f23402c4cb29bca6b98280fec48a196dec Gecko: 3436787a82d0 Gonk: e7c90613521145db090dd24147afd5ceb5703190 Version: 38.0a1 (3.0) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0 Repro frequency: 3/3, 100% See attached: screenshot
Reporter | ||
Comment 1•8 years ago
|
||
Issue DOES occur on Flame 2.2 Default search header does not appear in pre-3.0 builds, but the "History" header still appears and displays same behavior. Device: Flame 2.2 Build ID: 20150209002504 Gaia: e827781324cbde91d2434b388f5dead3303a85ee Gecko: 0552759956d3 Gonk: e7c90613521145db090dd24147afd5ceb5703190 Version: 37.0a2 (2.2) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0 Unable to check 2.1 due to lack of headers/different design in rocketbar search.
Comment 2•8 years ago
|
||
Hermes, can you take a look at this and weigh in on the severity of this issue?
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker) → needinfo?(hcheng)
Comment 3•8 years ago
|
||
According to the figures in UX spec, empty state should not have anything but only blank and the input bar. UX spec: https://mozilla.app.box.com/s/44utizl9oz4eupyu3fuu/1/2545278347/24162816989/1
blocking-b2g: --- → 2.2?
Flags: needinfo?(hcheng) → needinfo?(bfrancis)
Comment 4•8 years ago
|
||
Ben, could you take a look?
Updated•8 years ago
|
Whiteboard: [systemsfe]
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → apastor
Comment 6•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Attachment #8570431 -
Flags: review?(kgrandon)
Comment 7•8 years ago
|
||
Comment on attachment 8570431 [details] [review] [gaia] albertopq:1131408-headers-search > mozilla-b2g:master This looks great to me. Thanks for taking it!
Flags: needinfo?(bfrancis)
Attachment #8570431 -
Flags: review?(kgrandon) → review+
Updated•8 years ago
|
Keywords: checkin-needed
Updated•8 years ago
|
Keywords: checkin-needed
Comment 8•8 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/11ed97cf160ec161dff0889643d73e62daef570b
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 10•8 years ago
|
||
Comment on attachment 8570431 [details] [review] [gaia] albertopq:1131408-headers-search > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): - [User impact] if declined: Different behavior when clearing the search input through the keyboard or through the X button. The search headers remain visible on the second case [Testing completed]: Added unit tests. [Risk to taking this patch] (and alternatives if risky): Low risk. 1 liner with tests. [String changes made]: -
Flags: needinfo?(apastor)
Attachment #8570431 -
Flags: approval-gaia-v2.2?(bbajaj)
Updated•8 years ago
|
Attachment #8570431 -
Flags: approval-gaia-v2.2?(bbajaj) → approval-gaia-v2.2+
Comment 11•8 years ago
|
||
v2.2: https://github.com/mozilla-b2g/gaia/commit/9fb5d37d8e04d8e861af82c5354075029e820607
Target Milestone: --- → 2.2 S7 (6mar)
Comment 12•8 years ago
|
||
This issue is verified fixed for the latest Nightly 3.0 and 2.2 builds. Actual Results: The search results are cleared when pressing the x button. Environmental Variables: Device: Flame 3.0 KK (319 MB) (Full Flash) BuildID: 20150304010324 Gaia: 3fc0ac309f5fb0c1fe82c12223b955a4efce27e6 Gecko: c5b90c003be8 Gonk: e7c90613521145db090dd24147afd5ceb5703190 Version: 39.0a1 (3.0) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0 Environmental Variables: Device: Flame 2.2 KK (319 MB) (Full Flash) BuildID: 20150304002529 Gaia: 8b4b3e4b7e7c308764f71542437fd60625ac6b75 Gecko: 2cb52b7cda5a Gonk: e7c90613521145db090dd24147afd5ceb5703190 Version: 37.0 (2.2) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
Keywords: verifyme
Updated•8 years ago
|
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
You need to log in
before you can comment on or make changes to this bug.
Description
•