1131408 - [Search] Clearing search term in Rocketbar leaves History and Default Search headers on screen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Description

[Brogan Zumwalt [Inactive]]

Attachment: Screenshot

Description:
When user searches for a term in Rocketbar then clears search term by pressing "X" button, the Default search header (e.g. "Google Search", "Yahoo Search", etc.) remains although no search results appear. If the search term brought up browsing history results, the "History" header will remain as well. Furthermore, if there were any Marketplace results, any remaining headers will be vertically offset by the amount of space that was previously taken up by the Marketplace results.

Repro Steps:
1) Update a Flame to 20150209010211
2) Tap Rocketbar and enter a search term
3) Tap "X" button on Rocketbar to clear search term

Actual:
Default search and History headers remain visible in search results area.

Expected:
Search result area is blank in an empty state.

Environmental Variables:
Device: Flame 3.0 Master
Build ID: 20150209010211
Gaia: 0d7b35f23402c4cb29bca6b98280fec48a196dec
Gecko: 3436787a82d0
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Repro frequency: 3/3, 100%
See attached: screenshot

Comment 1

[Brogan Zumwalt [Inactive]]

Issue DOES occur on Flame 2.2

Default search header does not appear in pre-3.0 builds, but the "History" header still appears and displays same behavior.

Device: Flame 2.2
Build ID: 20150209002504
Gaia: e827781324cbde91d2434b388f5dead3303a85ee
Gecko: 0552759956d3
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0


Unable to check 2.1 due to lack of headers/different design in rocketbar search.

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

Hermes, can you take a look at this and weigh in on the severity of this issue?

Comment 3

[Hermes Cheng (inactive after July 27, 2015)]

According to the figures in UX spec, empty state should not have anything but only blank and the input bar.

UX spec: https://mozilla.app.box.com/s/44utizl9oz4eupyu3fuu/1/2545278347/24162816989/1

Comment 4

[Hermes Cheng (inactive after July 27, 2015)]

Ben, could you take a look?

Comment 5

[Candice Serran (:cserran)]

Team confirms this is a blocker

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1131408-headers-search > mozilla-b2g:master

Comment 7

[Kevin Grandon :kgrandon]

Comment on attachment 8570431 [details] [review]
[gaia] albertopq:1131408-headers-search > mozilla-b2g:master

This looks great to me. Thanks for taking it!

Comment 8

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/11ed97cf160ec161dff0889643d73e62daef570b

Comment 9

[Hermes Cheng (inactive after July 27, 2015)]

Could you please uplift to v2.2? Thanks.

Comment 10

[Alberto Pastor [:albertopq]]

Comment on attachment 8570431 [details] [review]
[gaia] albertopq:1131408-headers-search > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): - 
[User impact] if declined: Different behavior when clearing the search input through the keyboard or through the X button. The search headers remain visible on the second case
[Testing completed]: Added unit tests.
[Risk to taking this patch] (and alternatives if risky): Low risk. 1 liner with tests.
[String changes made]: -

Comment 11

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/9fb5d37d8e04d8e861af82c5354075029e820607

Comment 12

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed for the latest Nightly 3.0 and 2.2 builds.

Actual Results:  The search results are cleared when pressing the x button.
	
Environmental Variables:
Device: Flame 3.0 KK (319 MB) (Full Flash)
BuildID: 20150304010324
Gaia: 3fc0ac309f5fb0c1fe82c12223b955a4efce27e6
Gecko: c5b90c003be8
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Environmental Variables:
Device: Flame 2.2 KK (319 MB) (Full Flash)
BuildID: 20150304002529
Gaia: 8b4b3e4b7e7c308764f71542437fd60625ac6b75
Gecko: 2cb52b7cda5a
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0