1131424 - Report error message when failing to open ctypes library

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Steve Fink [:sfink] [:s:]]

It is very irritating to diagnose failures when opening a library. (In my case, it turned out to be because I still had an undefined symbol, because I needed to include additional object files in my link when I had a certain #define).

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Report error message when failing to open ctypes library

I'm not sure who pays attention to ctypes these days.

Comment 2

[Steve Fink [:sfink] [:s:]]

Attachment: Report error message when failing to open ctypes library

I suppose I ought to let you review the version that compiles.

Comment 3

[Jason Orendorff [:jorendorff]]

Comment on attachment 8562429 [details] [diff] [review]
Report error message when failing to open ctypes library

Review of attachment 8562429 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ctypes/Library.cpp
@@ +146,5 @@
>  
>    PRLibrary* library = PR_LoadLibraryWithFlags(libSpec, 0);
>  
>    if (!library) {
> +    char *error = (char*) js_malloc(PR_GetErrorTextLength() + 1);

I guess the usual allocation function to match JS_free is JS_malloc, but your call.

@@ +154,2 @@
>  #ifdef XP_WIN
> +    JS_ReportError(cx, "couldn't open library %hs: %s", pathChars, error);

All right, %s is nullsafe...

Comment 4

[Steve Fink [:sfink] [:s:]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0e7e4e9718b7

Comment 5

[Steve Fink [:sfink] [:s:]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c43187545daa

Comment 6

[Steve Fink [:sfink] [:s:]]

check-style problems
https://hg.mozilla.org/integration/mozilla-inbound/rev/ab62fb74233b

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0320992e5b37