113143 - Cookie Module to call compact-policy parser in p3p module

Status: RESOLVED FIXED

(Core :: Networking: Cookies, defect)

Description

[Stephen P. Morse]

This is an offshoot of bug 104894.

Currently the cookie module has some code that is supposed to call on a p3p 
compact-policy parser in order to determine whether to accept, reject, or 
downgrade cookies received from the server.  However the code to parse the 
compact policies has not yet been checked in (see bug 104894).  So the calling 
code in the cookie module is temporarily commented out.  When the tarball in bug 
104894 is checked in, the code in the cookie module can be uncommented.

Comment 1

[Stephen P. Morse]

*** Bug 113896 has been marked as a duplicate of this bug. ***

Comment 2

[Jaime Rodriguez, Jr.]

what are the chances this will make 098?

Comment 3

[Stephen P. Morse]

That depends on the dependency bug 104894.  If that bug makes 0.9.8 (which 
it is currently targetted for), then there's an excellent chance that this one 
will also.  And the inverse is also true.

Comment 4

[Jaime Rodriguez, Jr.]

kewl ... looks like bug 104894 has been waiting for an r= for about a month.
cc'ing dp to see if he can review the dependency bug.

Comment 5

[Alec Flett]

My suggestion here is to make a generic interface that lives in the cookie
module, say nsICookiePolicy or something, and implement it in the P3P module.
then have either a well-known category that you enumerate, or have a well-known
ContractID that P3P registers itself with. The ContractID can be defined in a
cookie header file (maybe even nsICookiePolicy.idl or something) that can be
#included from P3P.

In any case, cookie should not be #include'ing any P3P header files.

Comment 6

[Stephen P. Morse]

Won't that mean that p3p will then have to include a cookie header file?  Or am 
I misunderstanding what you are asking for?

Comment 7

[Stephen P. Morse]

With just a few more hours to go, it's obvious that dependent bug 104894 isn't 
going to make it for 0.9.8.  Therefore neither will this one.  Retargetting for 
0.9.9

Comment 8

[Stephen P. Morse]

Attachment: Turn on the call to the compact policy parser

Comment 9

[Stephen P. Morse]

Attachment: No need to preload p3p dll

Comment 10

[jag (Peter Annema)]

Comment on attachment 69236 [details] [diff] [review]
No need to preload p3p dll

sr=jag

Comment 11

[Samir Gehani]

Comment on attachment 69236 [details] [diff] [review]
No need to preload p3p dll

r=sgehani

Comment 12

[Stephen P. Morse]

I'm sorry, I goofed.  The second patch does not obsolete the first one.  The 
second one contains only nsCookies.cpp modifications whereas the first one 
contains modifications for other files as well.  The modifications for the first 
patch for the files other than nsCookies.cpp are still valid.

Samir, jag, please review the non-nsCOokies.cpp portion of the first patch.  
Thanks.

Comment 13

[harishd]

Steve: 
 {"P3P Service",
    NS_P3PSERVICE_CID,
-   NS_P3PSERVICE_CONTRACTID,
+   NS_COOKIECONSENT_CONTRACTID,
    nsP3PServiceConstructor,
   }

Does this mean that P3P Service would be used for cookies only? Remember, policy
viewer will also depend on P3P service and so will the full policy ( in future ).

Comment 14

[Stephen P. Morse]

Policy viewer can simply use the interface that is in the cookie module.

Comment 15

[harishd]

Policy viewer has nothing to do with Cookies and IMO should not be using
interfaces in cookie module. 

Comment 16

[Stephen P. Morse]

Instead of saying what we shouldn't do, do you have a recommendation for what we 
should do?

Comment 17

[harishd]

Steve: I understand your frustration. Unfortunately, I don't have an answer to
this problem on top of my head. We need to think through.

Comment 18

[harishd]

Comment on attachment 68964 [details] [diff] [review]
Turn on the call to the compact policy parser

r=harishd

Comment 19

[jag (Peter Annema)]

Comment on attachment 68964 [details] [diff] [review]
Turn on the call to the compact policy parser

>Index: MANIFEST_IDL
>===================================================================
>RCS file: /cvsroot/mozilla/extensions/cookie/MANIFEST_IDL,v
>retrieving revision 1.2
>diff -u -r1.2 MANIFEST_IDL
>--- MANIFEST_IDL	31 Jan 2002 04:08:11 -0000	1.2
>+++ MANIFEST_IDL	12 Feb 2002 02:22:56 -0000
>@@ -3,3 +3,4 @@
> nsIImgManager.idl
> nsIPermission.idl
> nsIPermissionManager.idl
>+nsICookieConsent.idl
>\ No newline at end of file

sr=jag if you fix that (just add a blank line at the end of that file).

Comment 20

[Stephen P. Morse]

Patch checked in.