1131444 - B2G: Assertion failure: work_queue_.empty(), at message_loop.cc:410

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Kevin Chen[:kechen] (UTC + 8)]

I am working on another bug, Bug 1097479. And ran into this assertion error by running the mochitest test case I added :

  >Assertion failure: work_queue_.empty(),

  https://treeherder.mozilla.org/logviewer.html#?job_id=4522817&repo=try

When finishing the test and closing it, the assertion error happened. There is already another bug relative to this error Bug 986113. It said that is caused by the destroyed timing. But I have no idea to fix this.

This bug can be reproduced by running mochitest on nested oop and close it.
e.g, ./mach mochitest-plain --nested ./dom/base/test/test_Image_constructor.html

Comment 1

[Kevin Chen[:kechen] (UTC + 8)]

Hello Bill, I saw you had a discussion in bug 1090921,if you are available, are there any advice to this error. Thank you.

Comment 2

[Kevin Chen[:kechen] (UTC + 8)]

I've set some breakpoints to track the error, however the assertion error never happened when I doing so. This might be the timing issue like bug 986113 mentioned. I'll keep tracing it.

Comment 3

[Kershaw Chang [:kershaw]]

I found this is due to that PContentBridge is not closed when the content process is ended. After adding some code to close PContentBridge when got "content-child-shutdown", I don't see this failure anymore.
A patch will be uploaded later.

Comment 4

[Kershaw Chang [:kershaw]]

Attachment: Close PContentBridge when content process is ended

Kyle, could you please take a look at this patch?
I think it makes sense to close PContentBridge channel when the content process is going to shutdown. Thanks.

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8574006 [details] [diff] [review]
Close PContentBridge when content process is ended

Review of attachment 8574006 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

Comment 6

[Kershaw Chang [:kershaw]]

Attachment: Close PContentBridge when content process is ended, r=khuey

Carry reviewer's name.

Test result:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1194ede5d70a

Comment 7

[Kershaw Chang [:kershaw]]

Since this bug is fixed, clear the needinfo request.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cb931e2210e1

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cb931e2210e1