Closed Bug 1131454 Opened 5 years ago Closed 5 years ago

Don't add transceive req into RequestQueue in NfcMessageHandler.

Categories

(Firefox OS Graveyard :: NFC, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(blocking-b2g:2.2+, firefox36 wontfix, firefox37 wontfix, firefox38 fixed, b2g-v2.2 fixed, b2g-master fixed)

RESOLVED FIXED
2.2 S6 (20feb)
blocking-b2g 2.2+
Tracking Status
firefox36 --- wontfix
firefox37 --- wontfix
firefox38 --- fixed
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: allstars.chh, Assigned: allstars.chh)

References

Details

(Whiteboard: [p=1])

Attachments

(1 file)

Transceive Req shouldn't be added into mPendingReqQueue in NfcMessageHandler.cpp.
Attached patch Patch.Splinter Review
Attachment #8561907 - Flags: review?(dlee)
blocking-b2g: --- → 2.2?
Attachment #8561907 - Flags: review?(dlee) → review+
https://hg.mozilla.org/integration/b2g-inbound/rev/bc064f894ded
Whiteboard: [p=1]
Target Milestone: --- → 2.2 S6 (20feb)
Comment on attachment 8561907 [details] [diff] [review]
Patch.

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
Bug 1109456

User impact if declined: 
NFC operations will fail after calling IsoDep.transceive.

Testing completed:
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=79cc8eda92e2

Risk to taking this patch (and alternatives if risky):
No.

String or UUID changes made by this patch:
No
Attachment #8561907 - Flags: approval-mozilla-b2g37?
https://hg.mozilla.org/mozilla-central/rev/bc064f894ded
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
blocking-b2g: 2.2? → 2.2+
Attachment #8561907 - Flags: approval-mozilla-b2g37? → approval-mozilla-b2g37+
You need to log in before you can comment on or make changes to this bug.