1131471 - Enable Gbn & Gbun for Node.js build script

Status: RESOLVED WONTFIX

(Release Engineering :: General, defect, P2)

Description

[Ricky Chien [:rickychien] (inactive)]

Enable Gbn & Gbun for all platform including Linux/Mac/Windows in Try-server (gaia-try / try / b2g-inbound) and set invisible until M1 complete

Comment 1

[Ricky Chien [:rickychien] (inactive)]

See also build system plan Milestone 0: https://wiki.mozilla.org/Gaia/Build/RefactoringToNodejs#Milestone_0

In this bug, we want to create two test-suites Gbn (Gaia Build Node.js Test) and Gbun (Gaia Build Unit Node.js Test) on tryserver in order to protect Node.js build script and set it invisible during development stage until Milestone 1 finish. Notice both test-suites would be red for a while until Milestone 1 finish.

Additionally, tryserver has to pass RUN_ON_NODE=1 in their scripts when launching Gbn or Gbun.

Comment 2

[Ricky Chien [:rickychien] (inactive)]

Hi Ryan,

In addition to enable Gbn & Gbun, is it possible to enable both test suites on:

B2G Desktop Linux opt
B2G Desktop OS X opt
B2G Desktop Windows opt

thanks!

Comment 3

[Ed Morley [:emorley]]

If these are taskcluster jobs:
- enabling will need to be done by the taskcluster team (Testing::Taskcluster)
- support for the job names _don't_ need to be added to treeherder
- the jobs will be shown by default, and the sheriffs can only hide them once they start running (file a "hide job foo" bug in Tree Management::Visibility Requests).

If these are buildbot jobs:
- enabling will need to be done by release engineering (Release Engineering::General Automation)
- support for the job name _will_ need to be added to treeherder (file a bug in Tree Management::Data Ingestion)
- the jobs will be shown by default, and the sheriffs can only hide them once they start running (file a "hide job foo" bug in Tree Management::Visibility Requests).

Looking at the comments in this bug and the wiki, this seems like it's still at the "enable jobs" stage, so this part doesn't belong in a Treeherder component (file new bugs for the other stages above when ready :-)).

Comment 4

[Ricky Chien [:rickychien] (inactive)]

I would like to take this bug as meta bug regarding node.js build system and automation, then file other bugs mentioned on comment 3 depend on this for addressing follow-up issues.

Comment 5

[Chris Cooper [:coop] (he/him)]

Not sure what I'm being asked here, so I'll defer to catlee as the component owner.

However...

If these are new tests you want added, i.e. tests that aren't currently running elsewhere, at the very least we'll need:

* pointers to the scripts
* instructions about how to invoke them
* any assumptions the scripts make re: setup and environment

Comment 6

[Chris AtLee [:catlee]]

Are these to be incorporated into existing test suites, or is this a new test suite?

Comment 7

[Ricky Chien [:rickychien] (inactive)]

(In reply to Chris AtLee [:catlee] from comment #6)
> Are these to be incorporated into existing test suites, or is this a new
> test suite?

Not sure what's your test suite mean, I think our treeherder would be:

B2G Desktop Linux opt    B Gb Gbu Gbn Gbun ...
B2G Desktop OS X opt     B Gbn Gbun ...
B2G Desktop Windows opt  B Gbn Gbun ...

I would be great if we could run tests on OS X and Windows.

Comment 8

[Chris Cooper [:coop] (he/him)]

(In reply to Ricky Chien [:rickychien] from comment #7)
> (In reply to Chris AtLee [:catlee] from comment #6)
> > Are these to be incorporated into existing test suites, or is this a new
> > test suite?
> 
> Not sure what's your test suite mean, I think our treeherder would be:
> 
> B2G Desktop Linux opt    B Gb Gbu Gbn Gbun ...
> B2G Desktop OS X opt     B Gbn Gbun ...
> B2G Desktop Windows opt  B Gbn Gbun ...

That's the last step. We're at still at step #1 here.

What catlee and I are asking is *how* are these tests run. AFAICT, we don't current run Gbn & Gbun on any branch, which means that these are new tests.

* Are they variants of the existing Gb & Gbu test run with different params?
* If they are completely new tests, where do the scripts to run these tests live?
** Are they mozharness-based, or something else?
* How do we run these tests, i.e. what does a default command-line invocation look like?

Comment 9

[Ricky Chien [:rickychien] (inactive)]

(In reply to Chris Cooper [:coop] from comment #8)
> * Are they variants of the existing Gb & Gbu test run with different params?

Yes, just clone Gb / Gbu script and add an additional flag RUN_ON_NODE=1 behind [1] to enable node.js tests.

> * How do we run these tests, i.e. what does a default command-line
> invocation look like?

same as above

I'll file a bug for enabling node Gbu/Gb testing when RUN_ON_NODE=1

[1] https://dxr.mozilla.org/build:mozharness/source/scripts/gaia_build_integration.py#39

Comment 10

[Ricky Chien [:rickychien] (inactive)]

Our plan is going to do migration and merge it directly soon so it won't enable another node version Gb/Gbn.