1131497 - Running build-test.js on node.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect, P2)

Comment 1

[(Inactive after June) George Duan [:gduan] [:喬智]]

Nodejs for this script is not that urgent before new build plan. deassign myself, please feel free to take it if anyone is interested.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] scottwu:1131497-running-build-test-js-2 > mozilla-b2g:master

Comment 3

[Scott Wu [:scottwu]]

Comment on attachment 8711565 [details] [review]
[gaia] scottwu:1131497-running-build-test-js-2 > mozilla-b2g:master

I've created a new BUILD_CONFIG with " instead of ' because node gives error doing JSON.parse on the original. The original one has been renamed 'BUILD_CONFIG_XPC'. I'm not sure this is the best way to go about it. Please take a look first and let me know what you think. Thanks!

Comment 4

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8711565 [details] [review]
[gaia] scottwu:1131497-running-build-test-js-2 > mozilla-b2g:master

Thank you Scott for this build system patch.

I don't see any potential big issues on your patch and GBU & GB runs well for me.

Please make sure fix all comments on Github and re-verify again for `make` and `make build-test-unit` `make build-test-integration` before landing.

Comment 5

[Scott Wu [:scottwu]]

Thanks! A lot more concise now.
Landed.

Comment 6

[:Eli Perelman]

This change breaks the reference workload scripts. The values for BUILD_CONFIG are now using single quotes instead of the required double quotes, which is not valid JSON.

Comment 7

[Carsten Book [:Tomcat]]

need-info per comment #6

Comment 8

[GitHub Autolander Bot]

Attachment: [gaia] mozilla-b2g:revert-33945-1131497-running-build-test-js-2 > mozilla-b2g:master

Comment 9

[:Eli Perelman]

Reverted via: https://github.com/mozilla-b2g/gaia/commit/72eee26a153ab1c710a033691b64ccb1ba4ca339

Please switch BUILD_CONFIG to valid JSON before landing again, and run `make reference-workload-light` to ensure it also functions.

Comment 10

[GitHub Autolander Bot]

Attachment: [gaia] scottwu:1131497-running-build-test-js-2 > mozilla-b2g:master

Comment 11

[Scott Wu [:scottwu]]

Comment on attachment 8712559 [details] [review]
[gaia] scottwu:1131497-running-build-test-js-2 > mozilla-b2g:master

Hi Ricky, here's the updated patch. Confirmed working with |make reference-workload-light|

Comment 12

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8712559 [details] [review]
[gaia] scottwu:1131497-running-build-test-js-2 > mozilla-b2g:master

LGTM

Comment 13

[Scott Wu [:scottwu]]

Thanks Ricky. Merged to master.

:Eli Perelman thanks for spotting my mistake. It now runs `make reference-workload-light` without problem.

Comment 14

[Michael Henretty [:mikehenrty][:mhenretty]]

Sorry guys, had to revert this again. This patch keeps causing b2g-inbound build tests to fail with the error mentioned below. Looks like you changed args to be an object, but are still trying to use args.push.

09:43:59     INFO -  /home/worker/gaia/build/build-test.js:34
09:43:59     INFO -      args.push('-ig', '\\[Network Required\\]');
09:43:59     INFO -           ^
09:43:59     INFO -  TypeError: args.push is not a function
09:43:59     INFO -      at Object.exports.execute.options [as execute] (/home/worker/gaia/build/build-test.js:34:10)
09:43:59     INFO -      at [eval]:1:34
09:43:59     INFO -      at Object.exports.runInThisContext (vm.js:54:17)
09:43:59     INFO -      at Object.<anonymous> ([eval]-wrapper:6:22)
09:43:59     INFO -      at Module._compile (module.js:435:26)
09:43:59     INFO -      at node.js:578:27
09:43:59     INFO -      at doNTCallback0 (node.js:419:9)
09:43:59     INFO -      at process._tickCallback (node.js:348:13)
https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=16aef4cff269&selectedJob=3848718

reverted in master: https://github.com/mozilla-b2g/gaia/commit/3846c047a92f6696b39d9389f0e87d31ebd4da9d

Comment 15

[GitHub Autolander Bot]

Attachment: [gaia] scottwu:1131497-running-build-test-js-2 > mozilla-b2g:master

Comment 16

[Scott Wu [:scottwu]]

Comment on attachment 8713026 [details] [review]
[gaia] scottwu:1131497-running-build-test-js-2 > mozilla-b2g:master

One last time..

Comment 17

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8713026 [details] [review]
[gaia] scottwu:1131497-running-build-test-js-2 > mozilla-b2g:master

r+ and please fix the nit on Github. thx!

Comment 18

[Scott Wu [:scottwu]]

Resolved the `args` issue. 

Landed and hopefully everything passes this time.