Running homescreen-manager.js on node.js

RESOLVED FIXED

Status

Firefox OS
Gaia::Build
P1
normal
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: rickychien, Assigned: rickychien)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

2 years ago
Priority: -- → P1
(Assignee)

Updated

2 years ago
Assignee: nobody → rchien
Status: NEW → ASSIGNED
Created attachment 8705955 [details] [review]
[gaia] rickychien:homescreen-manager-to-node > mozilla-b2g:master
(Assignee)

Comment 2

2 years ago
Comment on attachment 8705955 [details] [review]
[gaia] rickychien:homescreen-manager-to-node > mozilla-b2g:master

Another simple path too. All of utils APIs used by homescreen-manager.js are stable now and I don't want try to use nodeHelper.require (so you don't have to ./diff.sh) here and just make sure all APIs are convert to utils common version.

Please help me review it again to ensure there has no crucial issue or unconverted utils APIs.
Attachment #8705955 - Flags: review?(scwwu)

Comment 3

2 years ago
Comment on attachment 8705955 [details] [review]
[gaia] rickychien:homescreen-manager-to-node > mozilla-b2g:master

Tested ok on a device and diff looks okay! r+
Attachment #8705955 - Flags: review?(scwwu) → review+
(Assignee)

Comment 4

2 years ago
Landed

https://github.com/mozilla-b2g/gaia/commit/aac56169b9baaa9a82094b3c759e63fe4c7d491c
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.