Closed
Bug 1131510
Opened 10 years ago
Closed 10 years ago
Running settings.js on node.js
Categories
(Firefox OS Graveyard :: Gaia::Build, defect, P1)
Firefox OS Graveyard
Gaia::Build
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rickychien, Assigned: gduan)
References
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → gduan
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8569659 [details] [review] [gaia] cctuan:1131510 > mozilla-b2g:master Hi Ricky, I've compared settings file with/without my patch. Please check, thanks!
Attachment #8569659 -
Flags: review?(ricky060709)
Reporter | ||
Comment 3•10 years ago
|
||
Comment on attachment 8569659 [details] [review] [gaia] cctuan:1131510 > mozilla-b2g:master This small patch seems fine to me. Remember to remove /* global exports, require */ on the top of file. thanks!
Attachment #8569659 -
Flags: review?(ricky060709) → review+
Assignee | ||
Comment 4•10 years ago
|
||
thanks, master: https://github.com/mozilla-b2g/gaia/commit/ee4281ae9bdc399fd98b5ad3efebbafedc577131
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•9 years ago
|
Priority: -- → P1
You need to log in
before you can comment on or make changes to this bug.
Description
•