1131514 - Remove deprecated watcher.js and monitor.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect, P3)

Comment 1

[Ricky Chien [:rickychien] (inactive)]

Both of them are node.js scripts but nobody use as daily development. Also, there are already existed and mature node packages for doing this well. It's time to abandon them and move forward to find out new watcher package in NPM world.

Comment 2

[Ricky Chien [:rickychien] (inactive)]

We should make sure these thing for this clean up:

1. remove watcher.js and monitor.js
2. remove used packages from package.json
3. remove watch command from Makefile

Comment 4

[Ricky Chien [:rickychien] (inactive)]

Hi Scott, I'd like to give your this bug as getting started and be your mentor to understand build system. 

Hints are mentioned on comment 2.

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] scottwu:1131514-remove-watcher-monitor > mozilla-b2g:master

Comment 6

[Scott Wu [:scottwu]]

Comment on attachment 8706295 [details] [review]
[gaia] scottwu:1131514-remove-watcher-monitor > mozilla-b2g:master

Hi Ricky, I've removed the watcher and monitor files, as well as the related references.

Please take a look. Thanks!

Comment 7

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8706295 [details] [review]
[gaia] scottwu:1131514-remove-watcher-monitor > mozilla-b2g:master

Great Job!
Congrats you've submitted first build system patch.

Remember to add r=@rickychien on commit before merging the patch. thx

Comment 8

[Scott Wu [:scottwu]]

Thanks Ricky! Merged to master.