Closed
Bug 1131514
Opened 10 years ago
Closed 9 years ago
Remove deprecated watcher.js and monitor.js
Categories
(Firefox OS Graveyard :: Gaia::Build, defect, P3)
Firefox OS Graveyard
Gaia::Build
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rickychien, Assigned: scottwu)
References
Details
Attachments
(1 file)
No description provided.
Reporter | ||
Comment 1•9 years ago
|
||
Both of them are node.js scripts but nobody use as daily development. Also, there are already existed and mature node packages for doing this well. It's time to abandon them and move forward to find out new watcher package in NPM world.
Summary: Running monitor.js on node.js → Remove deprecated watcher.js and monitor.js
Reporter | ||
Comment 2•9 years ago
|
||
We should make sure these thing for this clean up: 1. remove watcher.js and monitor.js 2. remove used packages from package.json 3. remove watch command from Makefile
Reporter | ||
Updated•9 years ago
|
Priority: -- → P3
Reporter | ||
Comment 4•9 years ago
|
||
Hi Scott, I'd like to give your this bug as getting started and be your mentor to understand build system. Hints are mentioned on comment 2.
Assignee: nobody → scwwu
Status: NEW → ASSIGNED
Comment 5•9 years ago
|
||
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8706295 [details] [review] [gaia] scottwu:1131514-remove-watcher-monitor > mozilla-b2g:master Hi Ricky, I've removed the watcher and monitor files, as well as the related references. Please take a look. Thanks!
Attachment #8706295 -
Flags: review?(rchien)
Reporter | ||
Comment 7•9 years ago
|
||
Comment on attachment 8706295 [details] [review] [gaia] scottwu:1131514-remove-watcher-monitor > mozilla-b2g:master Great Job! Congrats you've submitted first build system patch. Remember to add r=@rickychien on commit before merging the patch. thx
Attachment #8706295 -
Flags: review?(rchien) → review+
Assignee | ||
Comment 8•9 years ago
|
||
Thanks Ricky! Merged to master.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•