Closed Bug 1131516 Opened 10 years ago Closed 9 years ago

Running post-app.js on node.js

Categories

(Firefox OS Graveyard :: Gaia::Build, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::Build
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: rickychien, Assigned: rickychien)

References

Details

Attachments

(1 file)

[gaia] rickychien:post-app-to-node > mozilla-b2g:master
46 bytes, text/x-github-pull-request
scottwu
: review+
Details | Review
No description provided.
Assignee: nobody → ricky060709
Status: NEW → ASSIGNED
Assignee: rchien → nobody
Status: ASSIGNED → NEW
Priority: -- → P1
Assignee: nobody → rchien
Status: NEW → ASSIGNED
Comment on attachment 8709908 [details] [review] [gaia] rickychien:post-app-to-node > mozilla-b2g:master Yo! Scott, easy patch for post-app.js is coming! It's time to refactor post-app.js after migration of webapp-optimize.js is complete. You'll notice that performance has been improved since we no longer spawn a new process by nodeHelper to run every build steps in post-app.js.
Attachment #8709908 - Flags: review?(scwwu)
cpu 4:37.51 total -> cpu 1:17.75 total
Comment on attachment 8709908 [details] [review] [gaia] rickychien:post-app-to-node > mozilla-b2g:master Text strings are not displayed properly. Here's a sample of the diff from FTU: diff -r diffs/unzip/xpc/webapps/ftu.gaiamobile.org/application.unzip/index.html diffs/unzip/node/webapps/ftu.gaiamobile.org/application.unzip/index.html 2c2 < <html lang="en-US" dir="ltr"> --- > <html> 33,34c33,34 < <meta name="availableLanguages" content="en-US:201600211106, fr-x-psaccent:201600211106, ar-x-psbidi:201600211106"> < <link rel="localization" href="/locales-obj/index.{locale}.json"> --- > <meta name="availableLanguages" content="en-US:201600211107, fr-x-psaccent:201600211107, ar-x-psbidi:201600211107"> > <link rel="localization" href="/shared/locales/branding/branding.{locale}.properties"> 36,39c36,39 < < < < --- > <link rel="localization" href="/shared/locales/import_contacts/import_contacts.{locale}.properties"> > <link rel="localization" href="locales/ftu.{locale}.properties"> > <link rel="localization" href="/shared/locales/date/date.{locale}.properties"> > <link rel="localization" href="/shared/locales/tz/tz.{locale}.properties"> 131c131 < <meta content="2.5" name="appVersion"></head> --- > <meta name="appVersion" content="2.5"></head> 145c145 < <input id="pin-input" name="simpin" x-inputmode="digit" size="8" maxlength="8" type="password"> --- > <input id="pin-input" name="simpin" type="password" x-inputmode="digit" size="8" maxlength="8"> 148c148 < <span data-l10n-id="pinLastChanceMsg" class="lastchance hidden">This is your last chance to enter the correct PIN. Otherwise, you must enter the PUK code to use this SIM card.</span> --- > <span data-l10n-id="pinLastChanceMsg" class="lastchance hidden"></span>
Attachment #8709908 - Flags: review?(scwwu)
Comment on attachment 8709908 [details] [review] [gaia] rickychien:post-app-to-node > mozilla-b2g:master root cause is raised from async callback in webapp-optimize. There are some of asynchronize functions running in webapp-optimize and continue processing / modifying HTML files during webapp-zip (it should be next step after optimizing). I wrapped webapp-optimize with Promise so hope that can fix issue.
Attachment #8709908 - Flags: review?(scwwu)
Comment on attachment 8709908 [details] [review] [gaia] rickychien:post-app-to-node > mozilla-b2g:master Works now! Thanks for the patch. r+
Attachment #8709908 - Flags: review?(scwwu) → review+
Landed: https://github.com/mozilla-b2g/gaia/commit/8f3065e7a8141864a217904543a30c818debd562
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: