1131517 - Running post-manifest.js on node.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect, P1)

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] RickyChien:post-manifest-to-nodejs > mozilla-b2g:master

Comment 2

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8571380 [details] [review]
[gaia] RickyChien:post-manifest-to-nodejs > mozilla-b2g:master

Hi George, could you review it kindly thanks!

Comment 3

[Ricky Chien [:rickychien] (inactive)]

I fixed encoding issue when build system tries to pass an utf8 args into nsIProcess.run(), fixing it by invoking nsIProcess.runw() [1] for supporting utf16 characters.

[1] https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIProcess#runw%28%29

Comment 4

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8571380 [details] [review]
[gaia] RickyChien:post-manifest-to-nodejs > mozilla-b2g:master

LGTM, r=gduan.
However, run => runw, do u have any fail case for it?

Comment 5

[Ricky Chien [:rickychien] (inactive)]

(In reply to George Duan [:gduan] [:喬智] from comment #4)
> Comment on attachment 8571380 [details] [review]
> [gaia] RickyChien:post-manifest-to-nodejs > mozilla-b2g:master
> 
> LGTM, r=gduan.
> However, run => runw, do u have any fail case for it?

Yeah, after falling back to runw(), post-manifest.js gets garbled string in foreign languages while parsing manifest.webapp. Especially in apps/sms/manifest.webapp, it throws a syntax error when encountering "name": "訊息".

Comment 6

[Ricky Chien [:rickychien] (inactive)]

Landed in master
https://github.com/mozilla-b2g/gaia/commit/02a14c282c5fb391675246e627a10d1508418c40