Closed
Bug 1131517
Opened 10 years ago
Closed 10 years ago
Running post-manifest.js on node.js
Categories
(Firefox OS Graveyard :: Gaia::Build, defect, P1)
Firefox OS Graveyard
Gaia::Build
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rickychien, Assigned: rickychien)
References
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → ricky060709
Status: NEW → ASSIGNED
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8571380 [details] [review] [gaia] RickyChien:post-manifest-to-nodejs > mozilla-b2g:master Hi George, could you review it kindly thanks!
Attachment #8571380 -
Flags: review?(gduan)
Assignee | ||
Comment 3•10 years ago
|
||
I fixed encoding issue when build system tries to pass an utf8 args into nsIProcess.run(), fixing it by invoking nsIProcess.runw() [1] for supporting utf16 characters. [1] https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIProcess#runw%28%29
Comment 4•10 years ago
|
||
Comment on attachment 8571380 [details] [review] [gaia] RickyChien:post-manifest-to-nodejs > mozilla-b2g:master LGTM, r=gduan. However, run => runw, do u have any fail case for it?
Attachment #8571380 -
Flags: review?(gduan) → review+
Assignee | ||
Comment 5•10 years ago
|
||
(In reply to George Duan [:gduan] [:喬智] from comment #4) > Comment on attachment 8571380 [details] [review] > [gaia] RickyChien:post-manifest-to-nodejs > mozilla-b2g:master > > LGTM, r=gduan. > However, run => runw, do u have any fail case for it? Yeah, after falling back to runw(), post-manifest.js gets garbled string in foreign languages while parsing manifest.webapp. Especially in apps/sms/manifest.webapp, it throws a syntax error when encountering "name": "訊息".
Assignee | ||
Comment 6•10 years ago
|
||
Landed in master https://github.com/mozilla-b2g/gaia/commit/02a14c282c5fb391675246e627a10d1508418c40
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•9 years ago
|
Priority: -- → P1
You need to log in
before you can comment on or make changes to this bug.
Description
•