Closed Bug 1131522 Opened 9 years ago Closed 8 years ago

Running rebuild.js on node.js

Categories

(Firefox OS Graveyard :: Gaia::Build, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::Build
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: rickychien, Assigned: rickychien)

References

Details

Attachments

(1 file)

[gaia] rickychien:rebuild-to-node > mozilla-b2g:master
46 bytes, text/x-github-pull-request
scottwu
: review+
Details | Review 
      No description provided.
Assignee: nobody → ricky060709
Status: NEW → ASSIGNED
Assignee: rchien → nobody
Status: ASSIGNED → NEW
Priority: -- → P1
Assignee: nobody → rchien
Status: NEW → ASSIGNED
Comment on attachment 8706265 [details] [review]
[gaia] rickychien:rebuild-to-node > mozilla-b2g:master

Hey Scott,

I finished rebuild.js migration and leaved some comments on Github, please take a look and verify it with ./node-build-diff.sh.
Attachment #8706265 - Flags: review?(scwwu)
Comment on attachment 8706265 [details] [review]
[gaia] rickychien:rebuild-to-node > mozilla-b2g:master

Looks good and tested fine on device & diff. Thanks!
Attachment #8706265 - Flags: review?(scwwu) → review+
Landed in master:

https://github.com/mozilla-b2g/gaia/commit/38fa8efeb6bd5a8922b0939b79776028720f7af3
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: