Closed
Bug 1131524
Opened 10 years ago
Closed 9 years ago
Running shared-utils.js on node.js
Categories
(Firefox OS Graveyard :: Gaia::Build, defect, P1)
Firefox OS Graveyard
Gaia::Build
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rickychien, Assigned: rickychien)
References
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Updated•9 years ago
|
Priority: -- → P1
Comment 1•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → rchien
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8705957 [details] [review] [gaia] rickychien:shared-utils-to-node > mozilla-b2g:master Hey Scott, here is another super simple patch. Because it uses stable utils APIs, as a result I think its okay to read it directly and make sure there is no potential risks instead of running diff.sh manually. Feel free to ask me if you have question.
Attachment #8705957 -
Flags: review?(scwwu)
Comment 3•9 years ago
|
||
Comment on attachment 8705957 [details] [review] [gaia] rickychien:shared-utils-to-node > mozilla-b2g:master Looks good! r+
Attachment #8705957 -
Flags: review?(scwwu) → review+
Assignee | ||
Comment 4•9 years ago
|
||
Landed https://github.com/mozilla-b2g/gaia/commit/f82dc73822aa8a6e29b89cad2741888aedcda1c9
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•