Closed Bug 1131524 Opened 10 years ago Closed 9 years ago

Running shared-utils.js on node.js

Categories

(Firefox OS Graveyard :: Gaia::Build, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::Build
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: rickychien, Assigned: rickychien)

References

Details

Attachments

(1 file)

[gaia] rickychien:shared-utils-to-node > mozilla-b2g:master
46 bytes, text/x-github-pull-request
scottwu
: review+
Details | Review 
      No description provided.
Priority: -- → P1

  

  


Assignee: nobody → rchien
Status: NEW → ASSIGNED

    
    

    
  
Comment on attachment 8705957 [details] [review]
[gaia] rickychien:shared-utils-to-node > mozilla-b2g:master

Hey Scott, here is another super simple patch. Because it uses stable utils APIs, as a result I think its okay to read it directly and make sure there is no potential risks instead of running diff.sh manually.

Feel free to ask me if you have question.

  

  



        Attachment #8705957 -
        Flags: review?(scwwu)

    
    

    
  
Comment on attachment 8705957 [details] [review]
[gaia] rickychien:shared-utils-to-node > mozilla-b2g:master

Looks good! r+

  

  



        Attachment #8705957 -
        Flags: review?(scwwu) → review+

    
    

    
  
Landed

https://github.com/mozilla-b2g/gaia/commit/f82dc73822aa8a6e29b89cad2741888aedcda1c9

  

  


Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: