Closed
Bug 113156
Opened 24 years ago
Closed 24 years ago
<polyline> needs to close open subpaths before filling
Categories
(Core :: SVG, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bbaetz, Assigned: bbaetz)
References
()
Details
Attachments
(1 file, 1 obsolete file)
|
3.44 KB,
patch
|
Details | Diff | Splinter Review |
Note that we have to do this always, since the ART_MOVETO_OPEN has to be changed
to ART_MOVETO.
OK, this was a bit more than 20 lines, mainly because I didn't realise that we
had to do this for each subpath, not for each path. :)
Patch coming
|
Assignee | |
Updated•24 years ago
|
|
|
Assignee | |
Comment 1•24 years ago
|
||
|
|
||
Comment 2•24 years ago
|
||
We don't *always* have to do this. E.g. <polygon> elements make a call to
nsASVGPathBuilder::Close() to ensure that their ART_MOVETO_OPEN is changed to
ART_MOVETO. Also, most paths will be closed properly (using 'z'). Filling a non-
closed shape is probably the exception, hence I think we should check before re-
allocing.
|
|
Assignee | |
Comment 3•24 years ago
|
||
Attachment #60089 -
Attachment is obsolete: true
|
|
||
Comment 4•24 years ago
|
||
r=afri. Looks good to me.
|
|
Assignee | |
Comment 5•24 years ago
|
||
Checked into branch
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•