Closed Bug 1131626 Opened 9 years ago Closed 8 years ago

[e10s] Re-enable browser_bug295977_autoscroll_overflow.js and browser_keyevents_during_autoscrolling.js

Categories

(Toolkit :: General, defect)

Product:
Toolkit
Component:
General
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal
Points:
2

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla44
Tracking Flags:
Tracking Status
e10s + ---
firefox44 --- fixed

People

(Reporter: enndeakin, Assigned: enndeakin)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Fix the three autoscroll tests
23.92 KB, patch
Felipe
: review+
Details | Diff | Splinter Review 
These tests cause a pile of assertions and the child process crashes.

When dispatchEvent is called:

###!!! ASSERTION: This is unsafe! Fix the caller!: 'Error', file /builds/moz2/working/dom/events/EventDispatcher.cpp, line 487
#01: mozilla::EventDispatcher::DispatchDOMEvent(nsISupports*, mozilla::WidgetEvent*, nsIDOMEvent*, nsPresContext*, nsEventStatus*) (EventDispatcher.cpp:704, in XUL)

Then, when synthesizeKey is called:

###!!! ABORT: can't send sync message of a lesser priority than what's being dispatched: file /builds/moz2/working/ipc/glue/MessageChannel.cpp, line 1825

As well as a lot of "unsafe CPOW usage" warnings.
Blocks: e10s-tests
tracking-e10s: --- → +
Flags: firefox-backlog+
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED

    
  
Points: --- → 2

    
    

    
  
Comment on attachment 8624470 [details] [diff] [review]
Fix the three autoscroll tests

Looks ok:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=630054a346f5

        Attachment #8624470 -
        Flags: review?(felipc)

    
    

    
  
Comment on attachment 8624470 [details] [diff] [review]
Fix the three autoscroll tests

Review of attachment 8624470 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/content/tests/browser/browser_keyevents_during_autoscrolling.js
@@ +89,2 @@
>  
> +//yield new Promise(r => {});

remove commented line

        Attachment #8624470 -
        Flags: review?(felipc) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/958e4293006d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago

          status-firefox44:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44

          You need to log in
          before you can comment on or make changes to this bug.