1131626 - [e10s] Re-enable browser_bug295977_autoscroll_overflow.js and browser_keyevents_during_autoscrolling.js

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Neil Deakin]

These tests cause a pile of assertions and the child process crashes.

When dispatchEvent is called:

###!!! ASSERTION: This is unsafe! Fix the caller!: 'Error', file /builds/moz2/working/dom/events/EventDispatcher.cpp, line 487
#01: mozilla::EventDispatcher::DispatchDOMEvent(nsISupports*, mozilla::WidgetEvent*, nsIDOMEvent*, nsPresContext*, nsEventStatus*) (EventDispatcher.cpp:704, in XUL)

Then, when synthesizeKey is called:

###!!! ABORT: can't send sync message of a lesser priority than what's being dispatched: file /builds/moz2/working/ipc/glue/MessageChannel.cpp, line 1825

As well as a lot of "unsafe CPOW usage" warnings.

Comment 1

[Neil Deakin]

Attachment: Fix the three autoscroll tests

Comment 2

[Neil Deakin]

Comment on attachment 8624470 [details] [diff] [review]
Fix the three autoscroll tests

Looks ok:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=630054a346f5

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8624470 [details] [diff] [review]
Fix the three autoscroll tests

Review of attachment 8624470 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/content/tests/browser/browser_keyevents_during_autoscrolling.js
@@ +89,2 @@
>  
> +//yield new Promise(r => {});

remove commented line

Comment 4

[Neil Deakin]

https://hg.mozilla.org/integration/mozilla-inbound/rev/958e4293006dff60f8cb703335be335e9fc52ab6
Bug 1131626, fix autoscroll tests to work in e10s, r=felipe

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/958e4293006d