1131658 - In bluetoothd, check malloc failures by return value instead of errno

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

In bug 1131619, we found a case were malloc error checks by errno actually didn't work. It's probably safer to convert bluetoothd to use the common scheme of testing malloc errors by return value.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Github pull request for bluetoothd

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Github pull request for libfdio

Comment 3

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Comment on attachment 8565054 [details]
Github pull request for bluetoothd

r=me, set_wake_alarm_cb part probably need to be re-based.

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Let's block for this bug.

Comment 5

[Thomas Zimmermann [:tzimmermann] [:tdz]]

If v2.2 will be supported on the Z3, we should back-port this fix. Otherwise it's probably not important.

Comment 6

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Patch includes prevention of false positives and null checks.  I think it's a good idea to take these patches.

Comment 7

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Comment on attachment 8565054 [details]
Github pull request for bluetoothd

Updated Github pull request:

  - rebased onto bug 1130271

Comment 8

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Comment on attachment 8565056 [details]
Github pull request for libfdio

Updated Github pull request:

  - rebased onto bug 1130271

Comment 9

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Comment on attachment 8565054 [details]
Github pull request for bluetoothd

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 

  Bluetooth daemon on Sony Z3

User impact if declined: 

  There were problems with memory allocations on Z3. Users might see invalid
  out-of-memory errors on this device.

Testing completed: 

  Local builds and testing

Risk to taking this patch (and alternatives if risky): 

  Low. The patches implement a standard C pattern.

String or UUID changes made by this patch:

  None

Comment 10

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Comment on attachment 8565056 [details]
Github pull request for libfdio

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]

  Please see comment #9

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/platform_system_bluetoothd/commit/e0fc03e0a3062063c3c85996dcc881c0a49ed98d

Master: https://github.com/mozilla-b2g/platform_system_libfdio/commit/8f7d94ac711af4678169805137c6c42def39b3ed

Comment 12

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/platform_system_bluetoothd/commit/4b8294f1a07833fefe5f99c92be4b356e783e99e

v2.2: https://github.com/mozilla-b2g/platform_system_libfdio/commit/4f7546c61ce97257d5122fe2021625d21c4f4c60