In bluetoothd, check malloc failures by return value instead of errno
RESOLVED
FIXED
in 2.2 S6 (20feb)
Status
People
(Reporter: tzimmermann, Assigned: tzimmermann)
Tracking
Firefox Tracking Flags
(blocking-b2g:2.2+, b2g-v2.2 fixed, b2g-master fixed)
Details
Attachments
(2 attachments)
|
421 bytes,
text/html
|
shawnjohnjr
:
review+
bajaj
:
approval-mozilla-b2g37+
|
Details |
|
409 bytes,
text/html
|
shawnjohnjr
:
review+
bajaj
:
approval-mozilla-b2g37+
|
Details |
In bug 1131619, we found a case were malloc error checks by errno actually didn't work. It's probably safer to convert bluetoothd to use the common scheme of testing malloc errors by return value.
|
(Assignee) | |
Comment 1•4 years ago
|
||
|
|
(Assignee) | |
Updated•4 years ago
|
Summary: In bluetoothd, check malloc failures be return value instead of errno → In bluetoothd, check malloc failures by return value instead of errno
|
|
(Assignee) | |
Comment 2•4 years ago
|
||
Attachment #8565056 -
Flags: review?(shuang)
Comment on attachment 8565054 [details]
Github pull request for bluetoothd
r=me, set_wake_alarm_cb part probably need to be re-based.
Attachment #8565054 -
Flags: review?(shuang) → review+
Attachment #8565056 -
Flags: review?(shuang) → review+
|
|
(Assignee) | |
Comment 5•4 years ago
|
||
If v2.2 will be supported on the Z3, we should back-port this fix. Otherwise it's probably not important.
blocking-b2g: --- → 2.2?
Patch includes prevention of false positives and null checks. I think it's a good idea to take these patches.
blocking-b2g: 2.2? → 2.2+
|
|
(Assignee) | |
Comment 7•4 years ago
|
||
Comment on attachment 8565054 [details] Github pull request for bluetoothd Updated Github pull request: - rebased onto bug 1130271
|
|
(Assignee) | |
Comment 8•4 years ago
|
||
Comment on attachment 8565056 [details] Github pull request for libfdio Updated Github pull request: - rebased onto bug 1130271
|
|
(Assignee) | |
Updated•4 years ago
|
Keywords: checkin-needed
|
|
(Assignee) | |
Comment 9•4 years ago
|
||
Comment on attachment 8565054 [details] Github pull request for bluetoothd NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] Bug caused by (feature/regressing bug #): Bluetooth daemon on Sony Z3 User impact if declined: There were problems with memory allocations on Z3. Users might see invalid out-of-memory errors on this device. Testing completed: Local builds and testing Risk to taking this patch (and alternatives if risky): Low. The patches implement a standard C pattern. String or UUID changes made by this patch: None
Attachment #8565054 -
Flags: approval-mozilla-b2g37?
|
|
(Assignee) | |
Comment 10•4 years ago
|
||
Comment on attachment 8565056 [details] Github pull request for libfdio NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] Please see comment #9
Attachment #8565056 -
Flags: approval-mozilla-b2g37?
|
||
Comment 11•4 years ago
|
||
Master: https://github.com/mozilla-b2g/platform_system_bluetoothd/commit/e0fc03e0a3062063c3c85996dcc881c0a49ed98d Master: https://github.com/mozilla-b2g/platform_system_libfdio/commit/8f7d94ac711af4678169805137c6c42def39b3ed
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-b2g-v2.2:
--- → affected
status-b2g-master:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S6 (20feb)
|
||
Updated•4 years ago
|
Attachment #8565054 -
Flags: approval-mozilla-b2g37? → approval-mozilla-b2g37+
|
|
||
Updated•4 years ago
|
Attachment #8565056 -
Flags: approval-mozilla-b2g37? → approval-mozilla-b2g37+
|
|
||
Comment 12•4 years ago
|
||
v2.2: https://github.com/mozilla-b2g/platform_system_bluetoothd/commit/4b8294f1a07833fefe5f99c92be4b356e783e99e v2.2: https://github.com/mozilla-b2g/platform_system_libfdio/commit/4f7546c61ce97257d5122fe2021625d21c4f4c60
You need to log in
before you can comment on or make changes to this bug.
Description
•