Closed Bug 1131805 Opened 6 years ago Closed 6 years ago

remove remaining uses JS_GetParent and js::GetObjectParent

Categories

(Core :: XPConnect, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: sfink, Assigned: bzbarsky)

References

Details

Attachments

(2 files, 1 obsolete file)

Split out from bug 805052: remove all of the misc uses of parent outside the JS engine that do not have an individual bug filed for them. Items 1, 2, 3, 4, 7, 11, 13, 15 should all be trivial to fix once the rest are.
Those item numbers refer to bug 805052 comment 14.
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #8570320 - Attachment is obsolete: true
Attachment #8570320 - Flags: review?(jwalden+bmo)
Comment on attachment 8570319 [details] [diff] [review]
part 1.  Remove remaining JS_GetParent and js::GetObjectParent uses in Gecko

Review of attachment 8570319 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/BindingUtils.cpp
@@ +1796,3 @@
>    MOZ_ASSERT(js::GetGlobalForObjectCrossCompartment(oldParent) == oldParent);
>  
>    JS::Rooted<JSObject*> newParent(aCx, domClass->mGetParent(aCx, aObj));

Maybe file a followup for replacing 'parent' with 'global' for this stuff?
Attachment #8570319 - Flags: review?(bobbyholley) → review+
Attachment #8570334 - Flags: review?(jwalden+bmo) → review+
Depends on: 1131802
Depends on: 1131797
Blocks: 599438
Backed out patch 2 for assertion failures:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc86a4e16519
because it was needed for the backout of bug 1131802.  (I could have sliced, but didn't feel like it.)
Flags: needinfo?(bzbarsky)
https://hg.mozilla.org/mozilla-central/rev/badf6f5f22f3
https://hg.mozilla.org/mozilla-central/rev/41846743ab88
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.