Closed
Bug 1131805
Opened 6 years ago
Closed 6 years ago
remove remaining uses JS_GetParent and js::GetObjectParent
Categories
(Core :: XPConnect, defect)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: sfink, Assigned: bzbarsky)
References
Details
Attachments
(2 files, 1 obsolete file)
5.61 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
11.58 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
Split out from bug 805052: remove all of the misc uses of parent outside the JS engine that do not have an individual bug filed for them. Items 1, 2, 3, 4, 7, 11, 13, 15 should all be trivial to fix once the rest are.
![]() |
Assignee | |
Comment 1•6 years ago
|
||
Those item numbers refer to bug 805052 comment 14.
![]() |
Assignee | |
Comment 2•6 years ago
|
||
Attachment #8570319 -
Flags: review?(bobbyholley)
![]() |
Assignee | |
Updated•6 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
![]() |
Assignee | |
Comment 3•6 years ago
|
||
Attachment #8570320 -
Flags: review?(jwalden+bmo)
![]() |
Assignee | |
Comment 4•6 years ago
|
||
Attachment #8570334 -
Flags: review?(jwalden+bmo)
![]() |
Assignee | |
Updated•6 years ago
|
Attachment #8570320 -
Attachment is obsolete: true
Attachment #8570320 -
Flags: review?(jwalden+bmo)
Comment 5•6 years ago
|
||
Comment on attachment 8570319 [details] [diff] [review] part 1. Remove remaining JS_GetParent and js::GetObjectParent uses in Gecko Review of attachment 8570319 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/bindings/BindingUtils.cpp @@ +1796,3 @@ > MOZ_ASSERT(js::GetGlobalForObjectCrossCompartment(oldParent) == oldParent); > > JS::Rooted<JSObject*> newParent(aCx, domClass->mGetParent(aCx, aObj)); Maybe file a followup for replacing 'parent' with 'global' for this stuff?
Attachment #8570319 -
Flags: review?(bobbyholley) → review+
Updated•6 years ago
|
Attachment #8570334 -
Flags: review?(jwalden+bmo) → review+
Comment 6•6 years ago
|
||
Backed out patch 2 for assertion failures: https://hg.mozilla.org/integration/mozilla-inbound/rev/dc86a4e16519 because it was needed for the backout of bug 1131802. (I could have sliced, but didn't feel like it.)
Flags: needinfo?(bzbarsky)
![]() |
Assignee | |
Comment 7•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/badf6f5f22f3 is part 1. Will reland part 2 soon.
![]() |
Assignee | |
Comment 8•6 years ago
|
||
Part 2: https://hg.mozilla.org/integration/mozilla-inbound/rev/41846743ab88
Flags: needinfo?(bzbarsky)
Comment 9•6 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/badf6f5f22f3 https://hg.mozilla.org/mozilla-central/rev/41846743ab88
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in
before you can comment on or make changes to this bug.
Description
•