1131805 - remove remaining uses JS_GetParent and js::GetObjectParent

Status: RESOLVED FIXED

Description

[Steve Fink [:sfink] [:s:]]

Split out from bug 805052: remove all of the misc uses of parent outside the JS engine that do not have an individual bug filed for them. Items 1, 2, 3, 4, 7, 11, 13, 15 should all be trivial to fix once the rest are.

Comment 1

[Boris Zbarsky [PTO through Aug 25, :bzbarsky, bz on IRC]]

Those item numbers refer to bug 805052 comment 14.

Comment 2

[Boris Zbarsky [PTO through Aug 25, :bzbarsky, bz on IRC]]

Attachment: part 1. Remove remaining JS_GetParent and js::GetObjectParent uses in Gecko

Comment 3

[Boris Zbarsky [PTO through Aug 25, :bzbarsky, bz on IRC]]

Attachment: part 2. Remove remaining js::GetObjectParent and JS_GetParent uses in SpiderMonkey

Comment 4

[Boris Zbarsky [PTO through Aug 25, :bzbarsky, bz on IRC]]

Attachment: part 2. Remove remaining js::GetObjectParent and JS_GetParent uses in SpiderMonkey

Comment 5

[Bobby Holley (PTO until August 19)]

Comment on attachment 8570319 [details] [diff] [review]
part 1.  Remove remaining JS_GetParent and js::GetObjectParent uses in Gecko

Review of attachment 8570319 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/BindingUtils.cpp
@@ +1796,3 @@
>    MOZ_ASSERT(js::GetGlobalForObjectCrossCompartment(oldParent) == oldParent);
>  
>    JS::Rooted<JSObject*> newParent(aCx, domClass->mGetParent(aCx, aObj));

Maybe file a followup for replacing 'parent' with 'global' for this stuff?

Comment 6

[David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-7]

Backed out patch 2 for assertion failures:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc86a4e16519
because it was needed for the backout of bug 1131802.  (I could have sliced, but didn't feel like it.)

Comment 7

[Boris Zbarsky [PTO through Aug 25, :bzbarsky, bz on IRC]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/badf6f5f22f3 is part 1.  Will reland part 2 soon.

Comment 8

[Boris Zbarsky [PTO through Aug 25, :bzbarsky, bz on IRC]]

Part 2: https://hg.mozilla.org/integration/mozilla-inbound/rev/41846743ab88

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/badf6f5f22f3
https://hg.mozilla.org/mozilla-central/rev/41846743ab88