1131825 - Fennec distribution code doesn't handle localized preferences correctly

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mike Connor [:mconnor]]

More string vs. localized pref failure.

Comment 1

[Mike Connor [:mconnor]]

http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#7634 is the code in question.  Can we just use BrowserApp.getUALocalePref() here?

Comment 2

[:Margaret Leibovic]

(In reply to Mike Connor [:mconnor] from comment #1)
> http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/
> browser.js#7634 is the code in question.  Can we just use
> BrowserApp.getUALocalePref() here?

That sounds fine to me.

Comment 3

[Mike Connor [:mconnor]]

Attachment: fennecDistroFix2

Comment 4

[Mike Connor [:mconnor]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5321b4fff1ae

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 8562420 [details] [diff] [review]
fennecDistroFix2

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]:
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: low risk, only should impact localized distribution prefs.  Since this is now completely broken, the pending distribution we're working on is clearly the first and only consumer.
[String/UUID change made/needed]: none.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5321b4fff1ae

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2120ea25464c

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9295bf4a3442