Fennec distribution code doesn't handle localized preferences correctly

RESOLVED FIXED in Firefox 36

Status

()

Firefox for Android
General
--
critical
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mconnor, Assigned: mconnor)

Tracking

36 Branch
Firefox 38
All
Android
Points:
---

Firefox Tracking Flags

(firefox36 fixed, firefox37 fixed, firefox38 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
More string vs. localized pref failure.
(Assignee)

Comment 1

3 years ago
http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#7634 is the code in question.  Can we just use BrowserApp.getUALocalePref() here?

Comment 2

3 years ago
(In reply to Mike Connor [:mconnor] from comment #1)
> http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/
> browser.js#7634 is the code in question.  Can we just use
> BrowserApp.getUALocalePref() here?

That sounds fine to me.
(Assignee)

Comment 3

3 years ago
Created attachment 8562420 [details] [diff] [review]
fennecDistroFix2
Attachment #8562420 - Flags: review?(rnewman)
Assignee: nobody → mconnor
Status: NEW → ASSIGNED
Attachment #8562420 - Flags: review?(rnewman) → review+
(Assignee)

Comment 5

3 years ago
Comment on attachment 8562420 [details] [diff] [review]
fennecDistroFix2

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]:
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: low risk, only should impact localized distribution prefs.  Since this is now completely broken, the pending distribution we're working on is clearly the first and only consumer.
[String/UUID change made/needed]: none.
Attachment #8562420 - Flags: approval-mozilla-beta?
Attachment #8562420 - Flags: approval-mozilla-aurora?
status-firefox36: --- → affected
status-firefox37: --- → affected
status-firefox38: --- → affected
https://hg.mozilla.org/mozilla-central/rev/5321b4fff1ae
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox38: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
Attachment #8562420 - Flags: approval-mozilla-beta?
Attachment #8562420 - Flags: approval-mozilla-beta+
Attachment #8562420 - Flags: approval-mozilla-aurora?
Attachment #8562420 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.