1131862 - Use the new bzapi target_milestone_detail to display only the active milestones

Status: RESOLVED FIXED

(Tree Management :: Bugherder, defect)

Description

[Ed Morley [:emorley]]

In bug 1120782, it was requested that the list of active milestones be pruned for several products, so that the list shown in mcMerge was more manageable. 

However it was then discovered that bzapi returned _all_ milestones, even the inactive ones.

Bug 1124255 then added an additional property to https://bugzilla.mozilla.org/bzapi/configuration called target_milestone_detail - which gives not only the name found in target_milestone, but also:
* id
* is_active
* sortkey

We should switch to this, so we can filter on is_active == true, and only display the active milestones in the mcMerge UI.

Comment 1

[Ed Morley [:emorley]]

https://bugzilla.mozilla.org/bzapi/configuration

     "target_milestone" : [
        "---",
        "2.2 S12 (15may)",
...
        "DeveloperPhone"
     ],
     "target_milestone_detail" : [
        {
           "id" : 2336,
           "is_active" : true,
           "name" : "---",
           "sortkey" : 0
        },
        {
           "id" : 6718,
           "is_active" : true,
           "name" : "2.2 S12 (15may)",
           "sortkey" : 945
        },
...
        {
           "id" : 2337,
           "is_active" : false,
           "name" : "DeveloperPhone",
           "sortkey" : 10310
        }
     ],

Handled here:
https://hg.mozilla.org/webtools/tbpl/file/ee042d68178e/mcmerge/js/ConfigurationData.js#l44

Comment 2

[Ed Morley [:emorley]]

Attachment: Part 1: Rename testsuiteFlag to testsuiteFlagID

Comment 3

[Ed Morley [:emorley]]

Attachment: Part 2: Rename products to hasTestsuiteFlag

For consistency with ConfigurationData.milestones

Comment 4

[Ed Morley [:emorley]]

Attachment: Part 4: Combine the two loops that each iterate 'products'

Doesn't make sense to iterate through products twice. Moves the testsuiteFlagID
calculation up front, then generates 'milestones' and 'hasTestsuiteFlag' as part
of the same loop.

Comment 5

[Ed Morley [:emorley]]

Attachment: Part 5: Display only the active milestones

The bzapi config target_milestone property on each product returns all
milestones for that product, including the inactive ones. A new property has
been added to the API, of form:

     "target_milestone_detail" : [
        {
           "id" : 2336,
           "is_active" : true,
           "name" : "---",
           "sortkey" : 0
        },

We now use target_milestone_detail instead of target_milestone, and filter on
is_active to find only the active milestones. We use map() to flattern the list
of activate milestone names, so existing consumers do not need to be adjusted.

Comment 6

[Ed Morley [:emorley]]

Attachment: Part 3: Return early if 'products' missing from bzapi config

Check for the 'product' property up-front, rather than having conditionals on it
throughout. Also create a variable for products, to clean up the references.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8562825 [details] [diff] [review]
Part 3: Return early if 'products' missing from bzapi config

Review of attachment 8562825 [details] [diff] [review]:
-----------------------------------------------------------------

::: mcmerge/js/ConfigurationData.js
@@ +49,1 @@
>      // Parse Milestones 

Get this whitespace while you're here?

Comment 8

[Ryan VanderMeulen [:RyanVM]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #7)
> Get this whitespace while you're here?

Nevermind, I see you got it in the next patch.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8562823 [details] [diff] [review]
Part 5: Display only the active milestones

Review of attachment 8562823 [details] [diff] [review]:
-----------------------------------------------------------------

"Bug 1131862 - mcMerge: Display online the active milestones" - "only" ?

Comment 10

[Ed Morley [:emorley]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #9)
> "Bug 1131862 - mcMerge: Display online the active milestones" - "only" ?

Good spot - thank you for the review :-)

https://hg.mozilla.org/webtools/tbpl/rev/052e24e0e7a5
https://hg.mozilla.org/webtools/tbpl/rev/322347863a53
https://hg.mozilla.org/webtools/tbpl/rev/3b92d0e89f8f
https://hg.mozilla.org/webtools/tbpl/rev/51aa56262fc0
https://hg.mozilla.org/webtools/tbpl/rev/b7112fa3e56a