Closed Bug 1131901 Opened 5 years ago Closed 5 years ago

Add infallible version of PL_DHashTableAdd()

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox38 --- fixed

People

(Reporter: njn, Assigned: njn)

References

Details

Attachments

(2 files)

The hash table entry storage lazification in bug 1050035 was backed out due to instability. But parts 4 and 5, which added an infallible version of PL_DHashTableAdd(), should be able to land safely now.
I kept all the existing PL_DHashTableAdd() calls fallible, in order to be
conservative, except for the ones in nsAtomTable.cpp which already were
followed immediately by an abort on failure.
Comment on attachment 8562539 [details] [diff] [review]
(part 1) - Make PL_DHashTableAdd() infallible by default, and add a fallible alternative

Review of attachment 8562539 [details] [diff] [review]:
-----------------------------------------------------------------

Carrying over r+ from bug 1050035.
Attachment #8562539 - Flags: review+
Comment on attachment 8562542 [details] [diff] [review]
(part 2) - Make CCGraphBuilder::AddNode() infallible

Review of attachment 8562542 [details] [diff] [review]:
-----------------------------------------------------------------

Carrying over r+ from bug 1050035.
Attachment #8562542 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/ee592ac6cc90
https://hg.mozilla.org/mozilla-central/rev/9ccc4502a5f0
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
No longer blocks: 1144649
Depends on: 1144649
You need to log in before you can comment on or make changes to this bug.