1131901 - Add infallible version of PL_DHashTableAdd()

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Nicholas Nethercote [inactive]]

The hash table entry storage lazification in bug 1050035 was backed out due to instability. But parts 4 and 5, which added an infallible version of PL_DHashTableAdd(), should be able to land safely now.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Make PL_DHashTableAdd() infallible by default, and add a fallible alternative

I kept all the existing PL_DHashTableAdd() calls fallible, in order to be
conservative, except for the ones in nsAtomTable.cpp which already were
followed immediately by an abort on failure.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Make CCGraphBuilder::AddNode() infallible

Comment 3

[Nicholas Nethercote [inactive]]

Comment on attachment 8562539 [details] [diff] [review]
(part 1) - Make PL_DHashTableAdd() infallible by default, and add a fallible alternative

Review of attachment 8562539 [details] [diff] [review]:
-----------------------------------------------------------------

Carrying over r+ from bug 1050035.

Comment 4

[Nicholas Nethercote [inactive]]

Comment on attachment 8562542 [details] [diff] [review]
(part 2) - Make CCGraphBuilder::AddNode() infallible

Review of attachment 8562542 [details] [diff] [review]:
-----------------------------------------------------------------

Carrying over r+ from bug 1050035.

Comment 5

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ee592ac6cc90
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ccc4502a5f0

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ee592ac6cc90
https://hg.mozilla.org/mozilla-central/rev/9ccc4502a5f0