Symbol upload API should allow wildcards for uploads to private s3 bucket (*@domain.tld)

RESOLVED FIXED

Status

Socorro
Webapp
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: ted, Assigned: peterbe)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
We discussed this on IRC but I can't find that we ever filed a bug. We have some partners that upload symbols to our symbol server but whose symbols should not be publicly accessible (except as function names etc. in frames in crash reports). We have a private s3 bucket configured to hold these, but we need a way to direct specific users' symbol uploads to go to the private bucket.

I think peterbe had a solution in mind here, maybe just an admin toggle or config file entry that would force a user's uploads to always go to the private bucket. (We talked about this, and we don't want to make the users decide this when they upload because it's just a single partner right now and their uploads will always go to the private bucket.)
(Reporter)

Updated

3 years ago
Blocks: 1130138
(Assignee)

Updated

3 years ago
Depends on: 1085530
(Assignee)

Comment 1

3 years ago
The plan we have is described here: https://github.com/mozilla/socorro/pull/2607#issuecomment-73282698
Assignee: nobody → peterbe
(Reporter)

Comment 2

3 years ago
Did this land as part of that patch or was that just an idea? If it didn't land I have a slight tweak suggestion: let us set wildcards or at least match the email domain, so we could set like "*@adobe.com" and not have to fiddle with it if the user changes.
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2)
> Did this land as part of that patch or was that just an idea? If it didn't
> land I have a slight tweak suggestion: let us set wildcards or at least
> match the email domain, so we could set like "*@adobe.com" and not have to
> fiddle with it if the user changes.

This did land as part of that patch, let's adjust this bug to be about the wildcard feature.
Summary: Symbol upload API should allow configuring specific users' uploads to private s3 bucket → Symbol upload API should allow wildcards for uploads to private s3 bucket (*@domain.tld)
Status: NEW → ASSIGNED
Component: General → Webapp
(Assignee)

Comment 4

3 years ago
Created attachment 8616942 [details] [review]
Link to Github pull-request: https://github.com/mozilla/socorro/pull/2840
(Assignee)

Updated

3 years ago
Blocks: 1172693

Comment 5

3 years ago
Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/0a3b812aa7c9372e69d2d92710646aca264ba2f6
fixes bug 1131987 - symbol upload and wildcard emails for private

https://github.com/mozilla/socorro/commit/e0d45869f34db8f05a0e14af761cbd16be140f0a
Merge pull request #2840 from peterbe/bug-1131987-symbol-upload-and-wildcard-emails-for-private

fixes bug 1131987 - symbol upload and wildcard emails for private

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Reporter)

Comment 6

3 years ago
Thanks!
You need to log in before you can comment on or make changes to this bug.