44 bytes, text/x-github-pull-request
|Details | Review | Splinter Review|
We discussed this on IRC but I can't find that we ever filed a bug. We have some partners that upload symbols to our symbol server but whose symbols should not be publicly accessible (except as function names etc. in frames in crash reports). We have a private s3 bucket configured to hold these, but we need a way to direct specific users' symbol uploads to go to the private bucket. I think peterbe had a solution in mind here, maybe just an admin toggle or config file entry that would force a user's uploads to always go to the private bucket. (We talked about this, and we don't want to make the users decide this when they upload because it's just a single partner right now and their uploads will always go to the private bucket.)
The plan we have is described here: https://github.com/mozilla/socorro/pull/2607#issuecomment-73282698
Did this land as part of that patch or was that just an idea? If it didn't land I have a slight tweak suggestion: let us set wildcards or at least match the email domain, so we could set like "*@adobe.com" and not have to fiddle with it if the user changes.
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2) > Did this land as part of that patch or was that just an idea? If it didn't > land I have a slight tweak suggestion: let us set wildcards or at least > match the email domain, so we could set like "*@adobe.com" and not have to > fiddle with it if the user changes. This did land as part of that patch, let's adjust this bug to be about the wildcard feature.
Created attachment 8616942 [details] [review] Link to Github pull-request: https://github.com/mozilla/socorro/pull/2840
Commits pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/0a3b812aa7c9372e69d2d92710646aca264ba2f6 fixes bug 1131987 - symbol upload and wildcard emails for private https://github.com/mozilla/socorro/commit/e0d45869f34db8f05a0e14af761cbd16be140f0a Merge pull request #2840 from peterbe/bug-1131987-symbol-upload-and-wildcard-emails-for-private fixes bug 1131987 - symbol upload and wildcard emails for private