1132007 - Initialise _iccChannelCalback in RilContentHelper.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Krzysztof Mioduszewski[:tauzen]]

While running SecureElement code (Bug 879861) on master I've got "this._iccChannelCallback is undefined" error. _iccChannelCallback was introduced in Bug 1081789, and the original version of the patch actually initialised it. The initialisation line was probably lost while rebasing to master. It needs to be added back for SE API to work properly.

Comment 1

[Krzysztof Mioduszewski[:tauzen]]

Attachment: 0001-Bug-1132007-Initialise-_iccChannelCalback-in-RilCont.patch

Hi Edgar, since you reviewed the patches in Bug 1081789 could you take a look a this? From my perspective this looks like a regression caused by rebase.

Comment 2

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: blocker as it's blocking bug 879861 (SE)

Comment 3

[Edgar Chen [:edgar]]

Comment on attachment 8562758 [details] [diff] [review]
0001-Bug-1132007-Initialise-_iccChannelCalback-in-RilCont.patch

Review of attachment 8562758 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comment addressed. Thank you, kmioduszewski!

Please also help to add `_iccChannelCallback: null` right before `_addIccChannelCallback: function(requestId, channelCb) {` [1], just like what |_iccListeners| does [2].

[1] https://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/RILContentHelper.js#596
[2] https://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/RILContentHelper.js#561

Comment 4

[Krzysztof Mioduszewski[:tauzen]]

Attachment: (v1.1) 0001-Bug-1132007-Initialise-_iccChannelCalback-in-RilCont.patch

Thanks Edgar! I've updated the patch as you requested. Once I'll get a green try build I'll request checkin.

Comment 5

[Krzysztof Mioduszewski[:tauzen]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=171f0e2fdaa2

I think there's a global problem with OSX builds, apart from that everything seems to be ok.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/2b9834775157

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2b9834775157

Comment 8

[Krzysztof Mioduszewski[:tauzen]]

Comment on attachment 8563340 [details] [diff] [review]
(v1.1) 0001-Bug-1132007-Initialise-_iccChannelCalback-in-RilCont.patch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
Bug 1132007, see more details in comment 0
User impact if declined:
Broken Secure Element API feature - Bug 879861  
Testing completed: on device testing complete
Risk to taking this patch (and alternatives if risky): none
String or UUID changes made by this patch: none

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/575846ae59f9