1132089 - Regression: Default search engine overrode on browser upgrade

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: General, defect)

Description

[tallus]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:35.0) Gecko/20100101 Firefox/35.0
Build ID: 20150125222008

Steps to reproduce:

Searched by entering text in the awesome bar.


Actual results:

The results returned were from Yahoo not the default search engine I had set (which still showed as the default in settings).
I had to select another search engine, then reselect my first choice (DuckDuckGo) in order for the correct search engine to be used.


Expected results:

Search results should have come from the correct engine.

If there an error preventing it an error message should have been displayed, warning that the default engine could not be used and giving the user choice as to how to proceed.

Comment 1

[Aaron Train [:aaronmt]]

Which Firefox version are you using and was this happening after a browser update?

Comment 2

[tallus]

(In reply to Aaron Train [:aaronmt] from comment #1)
> Which Firefox version are you using and was this happening after a browser
> update?

Firefox 36 (Beta) on Android. Its showing up in the recently updated list in the Paystore, so yes.

Comment 3

[Aaron Train [:aaronmt]]

[Tracking Requested - why for this release]: Search default regression

Simple enough report, thanks! I can reproduce. Latest regression in our recent search changes.

Comment 4

[Aaron Train [:aaronmt]]

Steps to reproduce

i. Install 36.0b6, set DuckDuckGo as default
ii. Update to 36.0b8, default is marked as DuckDuckGo but Yahoo is the active 'default' search

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Aaron Train [:aaronmt] from comment #4)
> Steps to reproduce
> 
> i. Install 36.0b6, set DuckDuckGo as default
> ii. Update to 36.0b8, default is marked as DuckDuckGo but Yahoo is the
> active 'default' search

Can you reproduce on Nightly and Aurora?

Comment 6

[Aaron Train [:aaronmt]]

Noted in #mobile this might be fixed via http://hg.mozilla.org/releases/mozilla-beta/rev/ff6bff2f5694 which missed the last shipped candidate is on track for the next one

Comment 7

[Aaron Train [:aaronmt]]

Confirmed this works again settings the geoip.url to https://location.services.mozilla.com/v1/country?key=%MOZILLA_API_KEY%.

We can check again on next candidate and then confirm this as fixed.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Bug 1123974 might be related. It was only fixed very recently and would likely affect mobile in this scenario too.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Ah, indeed - given that we shipped bug 1108627 to 34, users that got that buggy 34 update would have a cached isUS value. Then bug 1117186 would cause a change on update to it, without the patch for bug 1123974. I assume bug 1117186 made it to beta before the patch for bug 1123974?

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to :Gavin Sharp [email: [e-mail]] from comment #9)
> Ah, indeed - given that we shipped bug 1108627 to 34, users that got that
> buggy 34 update would have a cached isUS value. Then bug 1117186 would cause
> a change on update to it, without the patch for bug 1123974. I assume bug
> 1117186 made it to beta before the patch for bug 1123974?

Could be. It looks like all possible patches are on Beta now though. The next Beta build should have everything we currently think could affect geo-ip search.

Comment 12

[tallus]

Another additional thing:

I set the default using the Google Now launcher to use Firefox. This is still set to use Yahoo despite it being changed back in my browser.

Not sure if this needs another bug report?

Comment 13

[Aaron Train [:aaronmt]]

(In reply to tallus from comment #12)
> Another additional thing:
> 
> I set the default using the Google Now launcher to use Firefox. This is
> still set to use Yahoo despite it being changed back in my browser.
> 
> Not sure if this needs another bug report?

This is known, unlikely to be fixed in 36: bug 1131087.

Comment 14

[Sylvestre Ledru [:Sylvestre]]

Aaron, do you know if that bug is now fixed? Thanks

Comment 15

[Aaron Train [:aaronmt]]

It is for me. I have yet to hear from anyone in the States (re: GeoIP) that it works for them. I'm the sole tester on this feature and I'm in Canada.

Comment 16

[Sylvestre Ledru [:Sylvestre]]

OK. Thanks. I am going to mark it as fixed then.

Comment 17

[Brad Lassey [:blassey] (use needinfo?)]

NI to kev to confirm for the US