Building the QT port fails because nsIDeviceContextSpecPS::GetPrinter() is not implemented for the concrete QT class.
By the way, some clean-up could be done in the nsDeviceContextSpecQT.cpp file: - Indentation is not that great: it does not render well on lxr. (http://lxr.mozilla.org/seamonkey/source/gfx/src/qt/nsDeviceContextSpecQT.cpp) - lines 260-265 could perhaps be moved up in the code, as 1- they are not really usefull at this place in the code (appart from the test line 251) 2- line 258, the return may create leaks, and if it doens't yet, any change to the code may be a risk to create one. Perhaps I didn't read the code correctly as indentation in LXR is bad and I may have counted bracets incorrectly...
Comment on attachment 60136 [details] [diff] [review] Get QT compiling again r=Roland.Mainz@informatik.med.uni-giessen.de
Attachment #60136 - Flags: review+
Patch has been checked in.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
What about the cleanup mentioned in comment #3, should I open a new bug?
Jerome Lacoste: > What about the cleanup mentioned in comment #3, should I open a new bug? Yes, please. And don't forget to CC: me... :)
Chris/Roland, can one of you please verify this fix and mark this bug VERIFIED-FIXED ? thanks..
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.