Closed Bug 1132165 Opened 5 years ago Closed 5 years ago

Refine padding of Voice input icon

Categories

(Firefox for Android :: General, defect)

x86
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 38
Tracking Status
firefox38 --- fixed

People

(Reporter: antlam, Assigned: mcomella)

References

(Blocks 1 open bug)

Details

Attachments

(3 files, 2 obsolete files)

Currently, it's spaced too far from the right. We should keep the same padding as the 'x' that appears in the same space. 

Can we update this to 12dp on the right hand side of the icon?

Attaching screenshot of current
Flags: needinfo?(mark.finkle)
We can easily set the padding between the text and the compound drawablw (the mic), but I don't see any way to set the padding between the drawable and the right edge. I assume we just use the regular paddingRight, but I don't know where the right place to set that in the "styles" would be.

Throwing to Mike or Martyn to provide some guidance.
Flags: needinfo?(michael.l.comella)
Flags: needinfo?(mhaigh)
Flags: needinfo?(mark.finkle)
Actually, this should apply to both the left and right padding of the voice icon.
The mic drawable has padding - I'll remove it via image magick, and add the correct amount of padding.
Assignee: nobody → michael.l.comella
Flags: needinfo?(michael.l.comella)
Flags: needinfo?(mhaigh)
(In reply to Michael Comella (:mcomella) from comment #3)
> The mic drawable has padding - I'll remove it via image magick, and add the
> correct amount of padding.

You = star *!
Attached image Screenshot after patch (obsolete) —
Had to do some eyeballing on the right side, but the left side should be 12dp.

What say you, antlam?
Attachment #8563529 - Flags: feedback?(alam)
/r/3783 - Bug 1132165 - Remove padding from mic drawable in editing mode and add padding to url bar. r=mfinkle

Pull down this commit:

hg pull review -r bc18ee6f3272a4924f2e6b5d2d3922c8dc3ae7ee
Attachment #8563531 - Flags: review?(mark.finkle)
Comment on attachment 8563531 [details]
MozReview Request: bz://1132165/mcomella

https://reviewboard.mozilla.org/r/3781/#review3017

Ship It!
Attachment #8563531 - Flags: review?(mark.finkle) → review+
(In reply to Michael Comella (:mcomella) from comment #5)
> Created attachment 8563529 [details]
> Screenshot after patch
> 
> Had to do some eyeballing on the right side, but the left side should be
> 12dp.
> 
> What say you, antlam?

It looks larger on the right. Can we subtract 1 dp from the right?
Flags: needinfo?(michael.l.comella)
(leaves review on in case 1 dp is too much to subtract)
Comment on attachment 8563531 [details]
MozReview Request: bz://1132165/mcomella

/r/3783 - Bug 1132165 - Remove padding from mic drawable in editing mode and add padding to url bar. r=mfinkle

Pull down this commit:

hg pull review -r 2c6a8a94cbf02e189aeb5da1f7ce438021598edb
Attachment #8563531 - Flags: review+ → review?(mark.finkle)
Comment on attachment 8563531 [details]
MozReview Request: bz://1132165/mcomella

8dp instead of 9 (:antlam via IRC)
Flags: needinfo?(michael.l.comella)
Attachment #8563531 - Flags: review?(mark.finkle) → review+
Attached image Screenshot after patch
antlam f+ via IRC.
Attachment #8563529 - Attachment is obsolete: true
Attachment #8563529 - Flags: feedback?(alam)
Attachment #8563607 - Flags: feedback+
https://hg.mozilla.org/mozilla-central/rev/f85b33641ef7
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
Attachment #8563531 - Attachment is obsolete: true
Attachment #8619427 - Flags: review+
You need to log in before you can comment on or make changes to this bug.