1132165 - Refine padding of Voice input icon

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: N6 Screenshot_2015-02-11-10-42-21.png

Currently, it's spaced too far from the right. We should keep the same padding as the 'x' that appears in the same space. 

Can we update this to 12dp on the right hand side of the icon?

Attaching screenshot of current

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

We can easily set the padding between the text and the compound drawablw (the mic), but I don't see any way to set the padding between the drawable and the right edge. I assume we just use the regular paddingRight, but I don't know where the right place to set that in the "styles" would be.

Throwing to Mike or Martyn to provide some guidance.

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Actually, this should apply to both the left and right padding of the voice icon.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

The mic drawable has padding - I'll remove it via image magick, and add the correct amount of padding.

Comment 4

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to Michael Comella (:mcomella) from comment #3)
> The mic drawable has padding - I'll remove it via image magick, and add the
> correct amount of padding.

You = star *!

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Screenshot after patch

Had to do some eyeballing on the right side, but the left side should be 12dp.

What say you, antlam?

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: bz://1132165/mcomella

/r/3783 - Bug 1132165 - Remove padding from mic drawable in editing mode and add padding to url bar. r=mfinkle

Pull down this commit:

hg pull review -r bc18ee6f3272a4924f2e6b5d2d3922c8dc3ae7ee

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8563531 [details]
MozReview Request: bz://1132165/mcomella

https://reviewboard.mozilla.org/r/3781/#review3017

Ship It!

Comment 8

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to Michael Comella (:mcomella) from comment #5)
> Created attachment 8563529 [details]
> Screenshot after patch
> 
> Had to do some eyeballing on the right side, but the left side should be
> 12dp.
> 
> What say you, antlam?

It looks larger on the right. Can we subtract 1 dp from the right?

Comment 9

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(leaves review on in case 1 dp is too much to subtract)

Comment 10

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8563531 [details]
MozReview Request: bz://1132165/mcomella

/r/3783 - Bug 1132165 - Remove padding from mic drawable in editing mode and add padding to url bar. r=mfinkle

Pull down this commit:

hg pull review -r 2c6a8a94cbf02e189aeb5da1f7ce438021598edb

Comment 11

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8563531 [details]
MozReview Request: bz://1132165/mcomella

8dp instead of 9 (:antlam via IRC)

Comment 12

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Screenshot after patch

antlam f+ via IRC.

Comment 13

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Thanks Mike!

Comment 14

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/f85b33641ef7

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f85b33641ef7

Comment 17

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1132165 - Remove padding from mic drawable in editing mode and add padding to url bar. r=mfinkle