1132185 - Put the tab queue behind a build flag

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Martyn Haigh (:mhaigh)]

To avoid letting unused code ride the trains. Even though the new UI will land pref'd off in m-c, we unconditionally ship the new resources/code in the APK right now.

Comment 1

[Martyn Haigh (:mhaigh)]

Attachment: Put the tab queue behind a build flag

Comment 2

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8563455 [details] [diff] [review]
Put the tab queue behind a build flag

Review of attachment 8563455 [details] [diff] [review]:
-----------------------------------------------------------------

I don't have much context on what is desired here, but this will add the flag.  However, by setting the flag=1 in confvars.sh, you're enabling it everywhere.  (Not just on Nightly.)  Is that what you want?  In any case, this looks fine for what it does.

Comment 3

[Martyn Haigh (:mhaigh)]

I'm adding a build flag because part of the tab queue work needed is to move the View intent filter form BrowserApp to a new activity.  I'm eager for this work to not mess with Nightly before it's ready and so hiding this behind a build flag feels right.

I don't want to enable this build flag by default, only if I have an entry (export MOZ_ANDROID_TAB_QUEUE=1) in my moz config.  It seems that I need to do a clobber for changes in mozconfig to take effect - is that right, or am I doing something wrong?

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8563455 [details] [diff] [review]
Put the tab queue behind a build flag


>diff --git a/mobile/android/confvars.sh b/mobile/android/confvars.sh

>+# Enable the tab queue. This will go away in Bug 1132507.
>+MOZ_ANDROID_TAB_QUEUE=1

Do not check in with this set. As Nick says, that will turn the feature "on" in Nightly. You should check in like this:

MOZ_ANDROID_TAB_QUEUE=

And then locally, set it "=1" in your own builds. Once you are ready to test the feature in Nightly, you can land a small patch to set the flag "=1". Then, we just need to make sure it's ready to go to Aurora when a merge happens. If the feature is not ready, we need to land a small patch on Aurora to set it back to "="

Comment 5

[Nick Alexander :nalexander [he/him]]

(In reply to Mark Finkle (:mfinkle) from comment #4)
> Comment on attachment 8563455 [details] [diff] [review]
> Put the tab queue behind a build flag
> 
> 
> >diff --git a/mobile/android/confvars.sh b/mobile/android/confvars.sh
> 
> >+# Enable the tab queue. This will go away in Bug 1132507.
> >+MOZ_ANDROID_TAB_QUEUE=1
> 
> Do not check in with this set. As Nick says, that will turn the feature "on"
> in Nightly. You should check in like this:
> 
> MOZ_ANDROID_TAB_QUEUE=
> 
> And then locally, set it "=1" in your own builds. Once you are ready to test
> the feature in Nightly, you can land a small patch to set the flag "=1".
> Then, we just need to make sure it's ready to go to Aurora when a merge
> happens. If the feature is not ready, we need to land a small patch on
> Aurora to set it back to "="

Actually, because you're testing with ifdef, it should be commented out (like READING_LIST).

Comment 6

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: bz://1132185/nalexander

/r/3851 - Bug 1132185 - Put the tab queue behind a build flag

Pull down this commit:

hg pull review -r 006d3619a5da0c09bc93424d67aa40504db1bec6

Comment 7

[Martyn Haigh (:mhaigh)]

https://hg.mozilla.org/integration/fx-team/rev/f457684b3610

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f457684b3610

Comment 10

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 1132185 - Put the tab queue behind a build flag