1132223 - Add IdToAccessible and IdToHyperTextAccessible to DocAccessibleChild to reduce code duplication

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

More IdToFooAccessible will be added later.

Comment 1

[Trevor Saunders (:tbsaunde)]

Comment on attachment 8563049 [details] [diff] [review]
patch

>+DocAccessibleChild::IdToHyperTextAccessible(const uint64_t& aID)

any reason this shouldn't be a const method?

>+{
>+  Accessible* acc = IdToAccessible(aID);
>+  return acc ? acc->AsHyperText() : nullptr;

assert if we have an acc it is HyperText?

> DocAccessibleChild::RecvTextSubstring(const uint64_t& aID,
>                                       const int32_t& aStartOffset,
>                                       const int32_t& aEndOffset,
>                                       nsString* aText)
> {
>-  Accessible* acc = mDoc->GetAccessibleByUniqueID((void*)aID);
>-  if (!acc || !acc->IsHyperText())
>+  HyperTextAccessible* acc = IdToHyperTextAccessible(aID);
>+  if (!acc) {
>     return false;
>+  }

lets return true here since it can happen in normal opteration.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v2

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6947464c0fb8

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6947464c0fb8