Closed Bug 1132273 Opened 6 years ago Closed 6 years ago

Crash reporter expects general.useragent.locale to be a simple string pref

Categories

(Firefox for Android Graveyard :: Locale switching and selection, defect)

All
Android
defect
Not set
normal

Tracking

(firefox43 fixed)

RESOLVED FIXED
Firefox 43
Tracking Status
firefox43 --- fixed

People

(Reporter: rnewman, Assigned: rnewman)

Details

Attachments

(1 file)

This was never reliably the case, and now it's reliably not the case.

All crash reports will show:

  useragent_locale 	chrome://global/locale/intl.properties

I have no idea where this code lives. Can anyone throw me a clue?
Flags: needinfo?(snorp)
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
I have no good ideas on how to write a test for this without savagely chopping up nsAppRunner. Thoughts?
Looks like :rnewman has this under control
Flags: needinfo?(snorp)
Comment on attachment 8563211 [details] [diff] [review]
Report general.useragent.locale correctly regardless of whether it's a simple or localized string. v1

Can this land without a test?
Attachment #8563211 - Flags: review?(mark.finkle)
Comment on attachment 8563211 [details] [diff] [review]
Report general.useragent.locale correctly regardless of whether it's a simple or localized string. v1

LGTM
Attachment #8563211 - Flags: review?(mark.finkle) → review+
url:        https://hg.mozilla.org/integration/fx-team/rev/6ab9ac65553587b61da5d187796c1a59e1631762
changeset:  6ab9ac65553587b61da5d187796c1a59e1631762
user:       Richard Newman <rnewman@mozilla.com>
date:       Thu Aug 13 14:46:13 2015 -0700
description:
Bug 1132273 - Report general.useragent.locale correctly regardless of whether it's a simple or localized string. r=mfinkle
https://hg.mozilla.org/mozilla-central/rev/6ab9ac655535
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.