1132273 - Crash reporter expects general.useragent.locale to be a simple string pref

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Locale switching and selection, defect)

Description

[Richard Newman [:rnewman]]

This was never reliably the case, and now it's reliably not the case.

All crash reports will show:

  useragent_locale 	chrome://global/locale/intl.properties

I have no idea where this code lives. Can anyone throw me a clue?

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

http://mxr.mozilla.org/mozilla-central/source/toolkit/xre/nsAppRunner.cpp#4051

Comment 2

[Richard Newman [:rnewman]]

Attachment: Report general.useragent.locale correctly regardless of whether it's a simple or localized string. v1

Untested.

Comment 3

[Richard Newman [:rnewman]]

I have no good ideas on how to write a test for this without savagely chopping up nsAppRunner. Thoughts?

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Maybe using this file as an example:
http://mxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/test/unit/test_crashreporter_crash.js#42

I see annotations being added and checked

Comment 5

[James Willcox (:snorp) ([e-mail]) (he/him)]

Looks like :rnewman has this under control

Comment 6

[Richard Newman [:rnewman]]

Comment on attachment 8563211 [details] [diff] [review]
Report general.useragent.locale correctly regardless of whether it's a simple or localized string. v1

Can this land without a test?

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8563211 [details] [diff] [review]
Report general.useragent.locale correctly regardless of whether it's a simple or localized string. v1

LGTM

Comment 8

[Richard Newman [:rnewman]]

url:        https://hg.mozilla.org/integration/fx-team/rev/6ab9ac65553587b61da5d187796c1a59e1631762
changeset:  6ab9ac65553587b61da5d187796c1a59e1631762
user:       Richard Newman <[e-mail]>
date:       Thu Aug 13 14:46:13 2015 -0700
description:
Bug 1132273 - Report general.useragent.locale correctly regardless of whether it's a simple or localized string. r=mfinkle

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6ab9ac655535