Closed Bug 1132295 Opened 9 years ago Closed 9 years ago

Remove support for RegExp.prototype.unicode until Unicode regular expressions are supported

Categories

(Core :: JavaScript: Standard Library, defect)

Product:
Core
Component:
JavaScript: Standard Library
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla38
Tracking Flags:
Tracking Status
firefox38 --- fixed

People

(Reporter: Waldo, Assigned: Waldo)

Details

Attachments

(1 file)

Patch
3.12 KB, patch
till
: review+
Details | Diff | Splinter Review 
People like to use the presence of a property to feature-test for what that property exposes, fairly often.  Adding a unicode getter that always returns false is true in a spec sense, but bad in a feature-testing sense.  We should remove it until we actually support Unicode regular expressions.
Attached patch Patch — — Splinter Review 

        Attachment #8563158 -
        Flags: review?(till)

    
    

    
  
Comment on attachment 8563158 [details] [diff] [review]
Patch

Review of attachment 8563158 [details] [diff] [review]:
-----------------------------------------------------------------

I agree. My bad for not vetoing it.

        Attachment #8563158 -
        Flags: review?(till) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/984e5db41c43
Status: ASSIGNED → RESOLVED
Closed: 9 years ago

          status-firefox38:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38

          You need to log in
          before you can comment on or make changes to this bug.