Closed
Bug 1132318
Opened 9 years ago
Closed 9 years ago
refine resolution/framerate selection
Categories
(Core :: WebRTC, defect)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
mozilla41
People
(Reporter: ruil2, Assigned: jesup)
References
Details
Attachments
(1 file)
8.08 KB,
patch
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_1) AppleWebKit/600.2.5 (KHTML, like Gecko) Version/8.0.2 Safari/600.2.5
update resolution/framerate according to SDP parameters.----combine SelectSendResolution with SelectSendFrameRate
Updated•9 years ago
|
Component: Untriaged → WebRTC
Product: Firefox → Core
Updated•9 years ago
|
Attachment #8563282 -
Attachment is patch: true
Comment 3•9 years ago
|
||
Comment on attachment 8563282 [details] [diff] [review] refine_select_WxHxFps.txt Review of attachment 8563282 [details] [diff] [review]: ----------------------------------------------------------------- I appears this patch applies on top of M-C, but it actually needs to apply on top of the patch to Bug 1127642 which just landed on M-I and should be on M-C tomorrow.
Assignee | ||
Comment 5•9 years ago
|
||
Dealt with via a new patch with r=bwc
Assignee: nobody → rjesup
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
OS: Mac OS X → All
Hardware: x86 → All
Comment 6•9 years ago
|
||
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/038159ccffe6 - at least Linux64, 10.6 and Win7 debug (or maybe those are the only platform where we still run it on every push, dunno) were asserting in mochitest-3, https://treeherder.mozilla.org/logviewer.html#?job_id=10503202&repo=mozilla-inbound, https://treeherder.mozilla.org/logviewer.html#?job_id=10503047&repo=mozilla-inbound, https://treeherder.mozilla.org/logviewer.html#?job_id=10503570&repo=mozilla-inbound
Comment 8•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6e74f27a5ab0
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Comment 9•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/e33bb7d234df
status-firefox40:
--- → fixed
Comment 10•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/48c9f45a00f2
status-firefox39:
--- → fixed
Comment 11•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-esr38/rev/9d14f9fe4b9c
status-firefox-esr38:
--- → fixed
Comment 12•9 years ago
|
||
Randell, is there any manual verification needed for this fix? If yes, could you (or anyone else) please give us some testing details?
Flags: needinfo?(rjesup)
Updated•9 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•