1132318 - refine resolution/framerate selection

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[karina]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_1) AppleWebKit/600.2.5 (KHTML, like Gecko) Version/8.0.2 Safari/600.2.5

Comment 1

[karina]

update resolution/framerate according to SDP parameters.----combine SelectSendResolution with SelectSendFrameRate

Comment 2

[karina]

Attachment: refine_select_WxHxFps.txt

Comment 3

[Ethan Hugg [:ehugg]]

Comment on attachment 8563282 [details] [diff] [review]
refine_select_WxHxFps.txt

Review of attachment 8563282 [details] [diff] [review]:
-----------------------------------------------------------------

I appears this patch applies on top of M-C, but it actually needs to apply on top of the patch to Bug 1127642 which just landed on M-I and should be on M-C tomorrow.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/08acee81ae64

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Dealt with via a new patch with r=bwc

Comment 6

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/038159ccffe6 - at least Linux64, 10.6 and Win7 debug (or maybe those are the only platform where we still run it on every push, dunno) were asserting in mochitest-3, https://treeherder.mozilla.org/logviewer.html#?job_id=10503202&repo=mozilla-inbound, https://treeherder.mozilla.org/logviewer.html#?job_id=10503047&repo=mozilla-inbound, https://treeherder.mozilla.org/logviewer.html#?job_id=10503570&repo=mozilla-inbound

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6e74f27a5ab0

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6e74f27a5ab0

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e33bb7d234df

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/48c9f45a00f2

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr38/rev/9d14f9fe4b9c

Comment 12

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Randell, is there any manual verification needed for this fix? If yes, could you (or anyone else) please give us some testing details?

Comment 13

[Randell Jesup [:jesup] (needinfo me)]

none needed