refine resolution/framerate selection

RESOLVED FIXED in Firefox 39

Status

()

Core
WebRTC
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: karina, Assigned: jesup)

Tracking

Trunk
mozilla41
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox39 fixed, firefox40 fixed, firefox41 fixed, firefox-esr38 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_1) AppleWebKit/600.2.5 (KHTML, like Gecko) Version/8.0.2 Safari/600.2.5
(Reporter)

Comment 1

3 years ago
update resolution/framerate according to SDP parameters.----combine SelectSendResolution with SelectSendFrameRate

Updated

3 years ago
Depends on: 1127642
(Reporter)

Comment 2

3 years ago
Created attachment 8563282 [details] [diff] [review]
refine_select_WxHxFps.txt
Component: Untriaged → WebRTC
Product: Firefox → Core

Updated

3 years ago
Attachment #8563282 - Attachment is patch: true

Comment 3

3 years ago
Comment on attachment 8563282 [details] [diff] [review]
refine_select_WxHxFps.txt

Review of attachment 8563282 [details] [diff] [review]:
-----------------------------------------------------------------

I appears this patch applies on top of M-C, but it actually needs to apply on top of the patch to Bug 1127642 which just landed on M-I and should be on M-C tomorrow.

Comment 4

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/08acee81ae64
(Assignee)

Comment 5

3 years ago
Dealt with via a new patch with r=bwc
Assignee: nobody → rjesup
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
OS: Mac OS X → All
Hardware: x86 → All
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/038159ccffe6 - at least Linux64, 10.6 and Win7 debug (or maybe those are the only platform where we still run it on every push, dunno) were asserting in mochitest-3, https://treeherder.mozilla.org/logviewer.html#?job_id=10503202&repo=mozilla-inbound, https://treeherder.mozilla.org/logviewer.html#?job_id=10503047&repo=mozilla-inbound, https://treeherder.mozilla.org/logviewer.html#?job_id=10503570&repo=mozilla-inbound

Comment 7

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/6e74f27a5ab0
https://hg.mozilla.org/mozilla-central/rev/6e74f27a5ab0
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
https://hg.mozilla.org/releases/mozilla-aurora/rev/e33bb7d234df
status-firefox40: --- → fixed
https://hg.mozilla.org/releases/mozilla-beta/rev/48c9f45a00f2
status-firefox39: --- → fixed
https://hg.mozilla.org/releases/mozilla-esr38/rev/9d14f9fe4b9c
status-firefox-esr38: --- → fixed
Randell, is there any manual verification needed for this fix? If yes, could you (or anyone else) please give us some testing details?
Flags: needinfo?(rjesup)
(Assignee)

Comment 13

3 years ago
none needed
Flags: needinfo?(rjesup)
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.