Closed Bug 1132328 Opened 5 years ago Closed 5 years ago

remove TrackBuffer::mCurrentDecoder handling from RemoveDecoder()

Categories

(Core :: Audio/Video, defect)

x86_64
All
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox37 --- fixed
firefox38 --- fixed

People

(Reporter: karlt, Assigned: karlt)

Details

Attachments

(1 file)

After considering bug 1092915 comment 15, jya and I concluded that it was
actually not necessary for TrackBuffer::RemoveDecoder() to clear
mCurrentDecoder.  Instead SourceBuffer (and the parts of TrackBuffer called
from SourceBuffer, on the main thread) and the mInitializationPromise handling
can manage mCurrentDecoder.
This patch includes removal of the effects of all changes made in
https://hg.mozilla.org/mozilla-central/rev/1eed7ad9fbb7 except for the logging
added and code moved.
Attachment #8563205 - Flags: review?(jyavenard)
Attachment #8563205 - Flags: review?(jyavenard) → review+
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/366a3d38c09e
https://hg.mozilla.org/mozilla-central/rev/9f40d0612b71
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Comment on attachment 8563205 [details] [diff] [review]
remove mCurrentDecoder handling from RemoveDecoder()

Requesting 37 uplift for this patch and its followup fix.

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Less consistent testing, harder to port later changes.
[Describe test coverage new/current, TreeHerder]: Landed on m-c.
[Risks and why]: This change in MSE-specific, so the risk of a regression outside that feature is minimal. We're trying to get that feature out for the first time, so taking the change is better than not.
[String/UUID change made/needed]: None.
Attachment #8563205 - Flags: approval-mozilla-aurora?
Comment on attachment 8563205 [details] [diff] [review]
remove mCurrentDecoder handling from RemoveDecoder()

As stated, this bug was pre-approved to land with a set of changes for MSE. Marking the approval after the fact.
Attachment #8563205 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.