1132328 - remove TrackBuffer::mCurrentDecoder handling from RemoveDecoder()

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Karl Tomlinson (:karlt)]

After considering bug 1092915 comment 15, jya and I concluded that it was
actually not necessary for TrackBuffer::RemoveDecoder() to clear
mCurrentDecoder.  Instead SourceBuffer (and the parts of TrackBuffer called
from SourceBuffer, on the main thread) and the mInitializationPromise handling
can manage mCurrentDecoder.

Comment 1

[Karl Tomlinson (:karlt)]

Attachment: remove mCurrentDecoder handling from RemoveDecoder()

This patch includes removal of the effects of all changes made in
https://hg.mozilla.org/mozilla-central/rev/1eed7ad9fbb7 except for the logging
added and code moved.

Comment 2

[Karl Tomlinson (:karlt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/366a3d38c09e
https://hg.mozilla.org/integration/mozilla-inbound/rev/9f40d0612b71

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/366a3d38c09e
https://hg.mozilla.org/mozilla-central/rev/9f40d0612b71

Comment 4

[Ralph Giles (:rillian)]

Comment on attachment 8563205 [details] [diff] [review]
remove mCurrentDecoder handling from RemoveDecoder()

Requesting 37 uplift for this patch and its followup fix.

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Less consistent testing, harder to port later changes.
[Describe test coverage new/current, TreeHerder]: Landed on m-c.
[Risks and why]: This change in MSE-specific, so the risk of a regression outside that feature is minimal. We're trying to get that feature out for the first time, so taking the change is better than not.
[String/UUID change made/needed]: None.

Comment 5

[Ralph Giles (:rillian)]

Pushed to aurora with pre-approval from lmandel.

https://hg.mozilla.org/releases/mozilla-aurora/rev/bdbae3abf53f
https://hg.mozilla.org/releases/mozilla-aurora/rev/2580e92051c6

Comment 6

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8563205 [details] [diff] [review]
remove mCurrentDecoder handling from RemoveDecoder()

As stated, this bug was pre-approved to land with a set of changes for MSE. Marking the approval after the fact.