Closed Bug 1132349 Opened 5 years ago Closed 4 years ago

Test for removing focus when pagehide/submit/beforeunload

Categories

(Core :: DOM: Device Interfaces, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: timdream, Assigned: timdream)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1122463 +++

Need long overdue tests for bug 1122463 and bug 820057.
Assignee: nobody → timdream
Status: NEW → ASSIGNED
Attached patch Patch v1.0Splinter Review
:smaug, I am not sure if you should review this or if it's ok to have Jan review it, so I've set you for feedback.

Jan, this patch adds a test case to ensure we got a notification when the focus is removed.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=138452b00839
Attachment #8622392 - Flags: review?(janjongboom)
Attachment #8622392 - Flags: feedback?(bugs)
Comment on attachment 8622392 [details] [diff] [review]
Patch v1.0

jan could review
Attachment #8622392 - Flags: feedback?(bugs)
Comment on attachment 8622392 [details] [diff] [review]
Patch v1.0

r=me, but I do see this in the logs.

JavaScript error: resource://gre/modules/Keyboard.jsm, line 320: ReferenceError: SystemAppProxy is not defined

Probably because I'm not running the tests in b2g, but we should still fix it.
Attachment #8622392 - Flags: review?(janjongboom) → review+
(In reply to Jan Jongboom [:janjongboom] (Telenor) from comment #3)
> JavaScript error: resource://gre/modules/Keyboard.jsm, line 320:
> ReferenceError: SystemAppProxy is not defined

Agree we should fix this, but I don't know what would be a good way to do so.


(In reply to Pulsebot from comment #4)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/cf4421a96636

We should have r= tag on the commit message before check-in... I am told this doesn't warrant a backout but let's remember do so next time.
https://hg.mozilla.org/mozilla-central/rev/cf4421a96636
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
(In reply to Tim Guan-tin Chien [:timdream] (slow response; please ni? to queue) from comment #5)
> (In reply to Pulsebot from comment #4)
> > https://hg.mozilla.org/integration/mozilla-inbound/rev/cf4421a96636
> 
> We should have r= tag on the commit message before check-in... I am told
> this doesn't warrant a backout but let's remember do so next time.

Oh wait, did Pulsebot add that automatically?
You need to log in before you can comment on or make changes to this bug.