1132357 - remove h2-draft support starting in gecko-40

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Masatoshi Kimura [:emk]]

Will HTTP-WG keep messing around with the draft until our ClientHello header is filled up with the ALPN extension?

h2-14 was left because it was an implementation draft. But are h2-15 and h2-16 need to be advertised?

Comment 1

[Patrick McManus [:mcmanus]]

I expect -17 to go to the rfc editor, which means it will really be final as h2 and no-one will try and negotiate -17 in particular instead of -17. So we can probably wontfix this bug, but I'll wait for the standards action to happen before closing this.

We can kill all the draft versions soonish. gecko 40 sounds about right.

fwiw they've all been used at various points with overlap at the same point between all 3 versions. "implementation draft" isn't really a thing in practice and it really doesn't make a lot of sense if you want to get real feedback on the changes.

Comment 2

[Patrick McManus [:mcmanus]]

based on -17 going to proposed standard, we can change this bug to be remove draft-standard support starting in gecko 40. i.e. h2 only. (this should not impact spdy - that's a different bug and a different timeline.)

Comment 3

[u408661]

I've been looking forward to this ever since the day I started adding all those alpn tokens :) I'll write the patch, and we can have it hanging around waiting for 40 to be on m-c.

Comment 4

[u408661]

Attachment: patch

Comment 5

[u408661]

Huh, git-bz fail - it put my comment into the commit message of the patch instead of the comment (maybe I put it in the wrong place in the file, who knows). Anyway:

This should hit all the high points. Obviously, I'll wait until m-c becomes gecko 40 to land (assuming this is r+'d)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e119e99603ef

Comment 6

[Patrick McManus [:mcmanus]]

Comment on attachment 8573426 [details] [diff] [review]
patch

Review of attachment 8573426 [details] [diff] [review]:
-----------------------------------------------------------------

landing is contingent on having a RFC number to point to

Comment 7

[u408661]

Added RFC numbers in appropriate files. Hooray!

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/dc3c55cedb3f

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/dc3c55cedb3f

Comment 9

[Kohei Yoshino]

Added the site compatibility doc: https://www.fxsitecompat.com/en-US/docs/2015/http-2-draft-is-no-longer-supported/

Comment 10

[Jean-Yves Perrier [:teoli]]

Added a note: https://developer.mozilla.org/en-US/Firefox/Releases/41#Networking