Closed Bug 1132448 Opened 10 years ago Closed 10 years ago

ConnectionManager logs are too noisy when continuously trying to connect

Categories

(DevTools :: General, defect)

Product:
DevTools
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox38 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 38
Tracking Flags:
Tracking Status
firefox38 --- fixed

People

(Reporter: janx, Assigned: janx)

References

Details

Attachments

(1 file)

Don't log CONNECTION_REFUSED errors when they're expected.
2.16 KB, patch
ochameau
: review+
Details | Diff | Splinter Review
When you try to connect to a server before it's ready, you create a connection with `keepConnecting = true`. This produces a lot of unnecessary error logs: console.error: Message: [Exception... "Component returned failure code: 0x804b000d (NS_ERROR_CONNECTION_REFUSED) [nsIInputStream.available]" nsresult: "0x804b000d (NS_ERROR_CONNECTION_REFUSED)" location: "JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/security/socket.js :: onInputStreamReady :: line 300" data: no] Stack: onInputStreamReady@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/security/socket.js:300:8 console.error: Message: [Exception... "Component returned failure code: 0x804b000d (NS_ERROR_CONNECTION_REFUSED) [nsIInputStream.available]" nsresult: "0x804b000d (NS_ERROR_CONNECTION_REFUSED)" location: "JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/security/socket.js :: onInputStreamReady :: line 300" data: no] Stack: onInputStreamReady@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/security/socket.js:300:8 console.error: Message: [Exception... "Component returned failure code: 0x804b000d (NS_ERROR_CONNECTION_REFUSED) [nsIInputStream.available]" nsresult: "0x804b000d (NS_ERROR_CONNECTION_REFUSED)" location: "JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/security/socket.js :: onInputStreamReady :: line 300" data: no] Stack: onInputStreamReady@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/security/socket.js:300:8 console.error: Message: [Exception... "Component returned failure code: 0x804b000d (NS_ERROR_CONNECTION_REFUSED) [nsIInputStream.available]" nsresult: "0x804b000d (NS_ERROR_CONNECTION_REFUSED)" location: "JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/security/socket.js :: onInputStreamReady :: line 300" data: no] Stack: onInputStreamReady@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/security/socket.js:300:8 console.error: Message: [Exception... "Component returned failure code: 0x804b000d (NS_ERROR_CONNECTION_REFUSED) [nsIInputStream.available]" nsresult: "0x804b000d (NS_ERROR_CONNECTION_REFUSED)" location: "JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/security/socket.js :: onInputStreamReady :: line 300" data: no] Stack: onInputStreamReady@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/security/socket.js:300:8 console.error: Message: [Exception... "Component returned failure code: 0x804b000d (NS_ERROR_CONNECTION_REFUSED) [nsIInputStream.available]" nsresult: "0x804b000d (NS_ERROR_CONNECTION_REFUSED)" location: "JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/security/socket.js :: onInputStreamReady :: line 300" data: no] Stack: onInputStreamReady@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/security/socket.js:300:8 [...] Let's consider these expected, and stop logging them.
Comment on attachment 8563387 [details] [diff] [review] Don't log CONNECTION_REFUSED errors when they're expected. This will make you happy.
Attachment #8563387 - Flags: review?(poirot.alex)
Attachment #8563387 - Flags: review?(poirot.alex) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/adc101cabb7f
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox38: --- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: