Closed
Bug 1132458
Opened 9 years ago
Closed 9 years ago
Improve mozharness l10n setup time
Categories
(Release Engineering :: Applications: MozharnessCore, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: massimo, Assigned: massimo)
Details
Attachments
(1 file)
1.76 KB,
patch
|
jlund
:
review+
massimo
:
checked-in+
|
Details | Diff | Splinter Review |
A full run of desktop repacks, 5 locales, takes about 48 minutes to complete (on windows). About 20 minutes are spent by setting up the environment: deleting old directories, updating hg, ... We should improve the set up time, for example we could use mozharness to download the initial en_US binary, skipping the first mach configure/make wget-en-US run.
Assignee | ||
Comment 1•9 years ago
|
||
We spend few minutes re-cloning everything because PurgeMixin.clobber(self, always_clobber_dirs=[objdir]) deletes the build/ directory too. This patch remove the dependency of DesktopSingleLocale from PurgeMixin, and deletes only the directories that need to be deleted.
Attachment #8573203 -
Flags: review?(jlund)
Comment 2•9 years ago
|
||
Comment on attachment 8573203 [details] [diff] [review] [mozharness] Bug 1132458 - remove PurgeMixin.patch Review of attachment 8573203 [details] [diff] [review]: ----------------------------------------------------------------- I'll trust in you to know the bits that should be and shouldn't be deleted each time. side effect of this is we lose the ability to do a full clobber (c['force_clobber']) and developer_mode though I don't think that really matters at this point and if we can safely speed this up, \o/
Attachment #8573203 -
Flags: review?(jlund) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8573203 [details] [diff] [review] [mozharness] Bug 1132458 - remove PurgeMixin.patch Thanks Jordan! landed: https://hg.mozilla.org/build/mozharness/rev/29e05187fb53
Attachment #8573203 -
Flags: checked-in+
Comment 4•9 years ago
|
||
In production: https://hg.mozilla.org/build/mozharness/rev/29e05187fb53
Assignee | ||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•